-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: fixed double tab and styles clickable card component #2290
[BD-46] fix: fixed double tab and styles clickable card component #2290
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2290 +/- ##
=======================================
Coverage 91.01% 91.01%
=======================================
Files 234 234
Lines 4138 4138
Branches 992 992
=======================================
Hits 3766 3766
Misses 365 365
Partials 7 7 ☔ View full report in Codecov by Sentry. |
0e1888d
to
3eed9de
Compare
3eed9de
to
1dc0aaf
Compare
13cf065
to
7f65aba
Compare
7f65aba
to
a136042
Compare
@@ -129,22 +129,25 @@ link styling to make its content appear as a regular text. | |||
const isExtraSmall = useMediaQuery({ maxWidth: breakpoints.extraSmall.maxWidth }); | |||
|
|||
return ( | |||
<Hyperlink destination="https://www.edx.org"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also change description of this section because right now it says that we wrap Card
with a link but we use as
prop instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! Looking forward to trying it out.
@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 20.39.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 21.0.0-alpha.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Issue: #2264
Deploy Preview
Card component
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist