Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-46] fix: fixed double tab and styles clickable card component #2290

Merged
merged 4 commits into from
May 19, 2023
Merged

[BD-46] fix: fixed double tab and styles clickable card component #2290

merged 4 commits into from
May 19, 2023

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented May 10, 2023 •
edited
Loading

Description

Issue: #2264

Deploy Preview

Card component

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

openedx-webhooks commented May 10, 2023 •
edited
Loading

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label May 10, 2023
@netlify
Copy link

netlify bot commented May 10, 2023 •
edited
Loading

✅ Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 169c6ac
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/645e1220a29dc00008bb0f91
😎 Deploy Preview https://deploy-preview-2290--paragon-openedx.netlify.app/components/card
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft May 10, 2023 14:31
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (5894df1) 91.01% compared to head (169c6ac) 91.01%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2290   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files         234      234           
  Lines        4138     4138           
  Branches      992      992           
=======================================
  Hits         3766     3766           
  Misses        365      365           
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/fixed-clickable-cards branch from 0e1888d to 3eed9de Compare May 11, 2023 09:39
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review May 11, 2023 09:45
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft May 11, 2023 09:48
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/fixed-clickable-cards branch from 3eed9de to 1dc0aaf Compare May 11, 2023 10:14
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review May 11, 2023 11:44
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/fixed-clickable-cards branch from 13cf065 to 7f65aba Compare May 11, 2023 12:01
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/fixed-clickable-cards branch from 7f65aba to a136042 Compare May 11, 2023 12:28
@viktorrusakov viktorrusakov linked an issue May 12, 2023 that may be closed by this pull request
[Card] Double tab stop on clickable cards (i.e., isClickable=true) wrapped in a Hyperlink. #2264
Closed
viktorrusakov
viktorrusakov reviewed May 12, 2023
View reviewed changes
src/Card/README.md
@@ -129,22 +129,25 @@ link styling to make its content appear as a regular text.
const isExtraSmall = useMediaQuery({ maxWidth: breakpoints.extraSmall.maxWidth });

return (
<Hyperlink destination="https://www.edx.org">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also change description of this section because right now it says that we wrap Card with a link but we use as prop instead.

kalebjdavenport
kalebjdavenport approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@kalebjdavenport kalebjdavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! Looking forward to trying it out.

@adamstankiewicz adamstankiewicz merged commit cf8a387 into openedx:master May 19, 2023
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@adamstankiewicz adamstankiewicz linked an issue May 19, 2023 that may be closed by this pull request
fix: Remove second tab stop for <HyperLink> wrapper around Card component #2200
Closed
@adamstankiewicz adamstankiewicz mentioned this pull request May 19, 2023
Closed
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.39.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.0.0-alpha.31 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

@kalebjdavenport kalebjdavenport kalebjdavenport approved these changes

@viktorrusakov viktorrusakov Awaiting requested review from viktorrusakov

Assignees
No one assigned
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
2U Blended Project
Status: Done
Milestone
No milestone
6 participants
@PKulkoRaccoonGang @openedx-webhooks @edx-semantic-release @adamstankiewicz @kalebjdavenport @viktorrusakov