Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] refactor: refactoring tokens of the Paragon documentation site #1736

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Nov 3, 2022

Description

Conduct a second refactoring of the Paragon documentation site.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Nov 3, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 59ec2b5
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6364c7d7f8000b000aa74160
😎 Deploy Preview https://deploy-preview-1736--paragon-openedx.netlify.app/foundations/layout
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/refactoring-design-tokens-in-doc-site branch 3 times, most recently from 195c377 to de0d067 Compare November 3, 2022 15:05
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feat/design-tokens@045290b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/design-tokens    #1736   +/-   ##
=====================================================
  Coverage                      ?   90.51%           
=====================================================
  Files                         ?      211           
  Lines                         ?     3713           
  Branches                      ?      872           
=====================================================
  Hits                          ?     3361           
  Misses                        ?      337           
  Partials                      ?       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@viktorrusakov viktorrusakov force-pushed the Peter_Kulko/refactoring-design-tokens-in-doc-site branch from de0d067 to 59ec2b5 Compare November 4, 2022 08:05
@viktorrusakov viktorrusakov merged commit 637c457 into openedx:feat/design-tokens Nov 4, 2022
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants