-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgraded to node v18, added .nvmrc and updated workflows #2227
Conversation
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2227 +/- ##
=======================================
Coverage 91.01% 91.01%
=======================================
Files 234 234
Lines 4139 4139
Branches 991 991
=======================================
Hits 3767 3767
Misses 365 365
Partials 7 7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, looks like there's a merge conflict with package-lock.json. Also, these changes should be released as a breaking change. Thanks!
…al-m/node18-upgrade
Hi @adamstankiewicz! Since there aren't any breaking changes in this PR and there is no major version change in package.json, i think we can release it as minor version. If you have any particular scenario in mind in which it can break, please let us know so we can proceed to merge it |
…al-m/node18-upgrade
🎉 This PR is included in version 20.38.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 21.0.0-alpha.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Ticket
Upgrade Node JS from 16 to 18
Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist