-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] docs: refactoring Usage Insights #2267
[BD-46] docs: refactoring Usage Insights #2267
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
9878669
to
1d4b9da
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2267 +/- ##
=======================================
Coverage 91.38% 91.38%
=======================================
Files 234 234
Lines 4120 4120
Branches 982 982
=======================================
Hits 3765 3765
Misses 348 348
Partials 7 7 ☔ View full report in Codecov by Sentry. |
f2d7cd2
to
c749d4e
Compare
c749d4e
to
37b283e
Compare
6c879ad
to
a3e58df
Compare
78a35a4
to
ffffcfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job cleaning up these "Usage Insights" related files! Should be more maintainable /
understandable / approachable moving forward.
case componentName.toLowerCase() === 'paragon': | ||
componentType = 'Paragon'; | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting; didn't know we had a usage of import * as paragon from '@edx/paragon';
!
} | ||
`); | ||
if (result.errors) { | ||
reporter.panicOnBuild('🚨 ERROR: Loading createPages query'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(lol at this function name panicOnBuild
)
@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 20.45.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Issue: #2318
Deploy Preview
Usage Insights
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist