Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] docs: extended Edx Typescript config #2309

Merged

Conversation

PKulkoRaccoonGang
Copy link
Contributor

Description

Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label May 17, 2023
@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for paragon-openedx failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 9a33eda
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6482c34759f7c600088c457f

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/extend-edx-ts-config branch 4 times, most recently from e0a9e40 to eea5cf3 Compare May 17, 2023 11:38
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (cf8a387) 91.38% compared to head (9a33eda) 91.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2309      +/-   ##
==========================================
+ Coverage   91.38%   91.40%   +0.01%     
==========================================
  Files         234      234              
  Lines        4120     4129       +9     
  Branches      982      986       +4     
==========================================
+ Hits         3765     3774       +9     
  Misses        348      348              
  Partials        7        7              

see 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/extend-edx-ts-config branch from 6bf32ab to 22be70c Compare May 22, 2023 08:36
@viktorrusakov viktorrusakov force-pushed the Peter_Kulko/extend-edx-ts-config branch from fc3bb1f to 9a33eda Compare June 9, 2023 06:14
@viktorrusakov viktorrusakov merged commit a390434 into openedx:master Jun 9, 2023
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Extend @edx/typescript-config in the tsconfig.json files
4 participants