Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] docs: add copy URL and reset buttons to playground page #2323

Merged

Conversation

viktorrusakov
Copy link
Contributor

@viktorrusakov viktorrusakov commented May 22, 2023

Description

Adds Copy URL and Reset buttons to the Playground page.

Deploy Preview

https://deploy-preview-2323--paragon-openedx.netlify.app/playground

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label May 22, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @viktorrusakov!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit 38cbcc0
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/646b548bc052d90007cc318b
😎 Deploy Preview https://deploy-preview-2323--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viktorrusakov viktorrusakov force-pushed the rusakov/add-reset-and-copy-url-buttons-to-playground branch from 75197cd to 6c3b42e Compare May 22, 2023 07:23
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf8a387) 91.38% compared to head (38cbcc0) 91.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2323   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         234      234           
  Lines        4120     4120           
  Branches      982      982           
=======================================
  Hits         3765     3765           
  Misses        348      348           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@viktorrusakov viktorrusakov force-pushed the rusakov/add-reset-and-copy-url-buttons-to-playground branch from 6c3b42e to 5558606 Compare May 22, 2023 07:46
www/src/pages/playground.tsx Outdated Show resolved Hide resolved
www/src/pages/playground.tsx Outdated Show resolved Hide resolved
@adamstankiewicz adamstankiewicz enabled auto-merge (squash) June 2, 2023 12:03
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamstankiewicz adamstankiewicz merged commit f95ddb4 into master Jun 2, 2023
@adamstankiewicz adamstankiewicz deleted the rusakov/add-reset-and-copy-url-buttons-to-playground branch June 2, 2023 12:07
@openedx-webhooks
Copy link

@viktorrusakov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[Playground] "Copy URL" in playground header and Segment events [Playground] Reset button
6 participants