Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: skeleton.css for both dev and prod #2531

Merged

Conversation

monteri
Copy link
Contributor

@monteri monteri commented Aug 11, 2023

Description

The issue was that in the prod environment Skeleton didn't show up. The fix is to use @use instead of @import.
#2420

Deploy Preview

https://deploy-preview-2531--paragon-openedx.netlify.app/components/skeleton/

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

openedx-webhooks commented Aug 11, 2023

Thanks for the pull request, @monteri!

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Aug 11, 2023
@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3495ab8
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64dca77081711000082dd4ae
😎 Deploy Preview https://deploy-preview-2531--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamstankiewicz adamstankiewicz marked this pull request as draft August 11, 2023 13:21
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b77488e) 91.65% compared to head (3495ab8) 91.65%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2531   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         236      236           
  Lines        4195     4195           
  Branches     1012     1012           
=======================================
  Hits         3845     3845           
  Misses        346      346           
  Partials        4        4           

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang
Copy link
Contributor

@adamstankiewicz @monteri checked for performance in the MFE frontend-app-course-authoring

@monteri monteri marked this pull request as ready for review August 18, 2023 11:14
@adamstankiewicz
Copy link
Member

@adamstankiewicz @monteri checked for performance in the MFE frontend-app-course-authoring

Great, thanks! I've also verified this change on my machine locally with the Paragon repo (docs site + example MFE) and the frontend-template-application MFE (npm start & npm run build) as well. Seems like we have sufficient confidence with this change to merge.

@adamstankiewicz adamstankiewicz enabled auto-merge (squash) August 18, 2023 12:18
@adamstankiewicz adamstankiewicz merged commit 7e96a0a into openedx:master Aug 18, 2023
9 checks passed
@openedx-webhooks
Copy link

@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program raccoon-gang released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants