Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: added Husky configurations #2949

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Dec 18, 2023

Description

  • added Husky configuration

Issue: #2864

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Dec 18, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 18, 2023

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bdbdbe3
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/658eac01083ec50008279c7b
😎 Deploy Preview https://deploy-preview-2949--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft December 18, 2023 17:22
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/create-husky-configuration branch 6 times, most recently from 8854ba8 to 6770b2a Compare December 19, 2023 20:40
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [BD-46] feat: added Husky configuration [BD-46] feat: added Husky and Prettier configurations Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4dcf111) 93.00% compared to head (bdbdbe3) 93.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2949   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files         236      236           
  Lines        4273     4273           
  Branches     1033     1033           
=======================================
  Hits         3974     3974           
  Misses        295      295           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review December 19, 2023 21:05
@viktorrusakov viktorrusakov linked an issue Dec 21, 2023 that may be closed by this pull request
Copy link
Contributor

@viktorrusakov viktorrusakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PKulkoRaccoonGang I left initial comments and will take a look later as well.

I think you should change printWidth setting in prettier config to match max line length setting that we have in eslint config. Otherwise, prettier does a lot of unnecessary changes by splitting what it thinks long lines into multiple lines

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
component-generator/templates/README.md Outdated Show resolved Hide resolved
src/Alert/README.md Outdated Show resolved Hide resolved
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/create-husky-configuration branch 3 times, most recently from 810c708 to c78d304 Compare December 22, 2023 13:33
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/create-husky-configuration branch 2 times, most recently from 1b1f608 to 3608692 Compare December 27, 2023 14:13
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [BD-46] feat: added Husky and Prettier configurations [BD-46] feat: added Husky configurations Dec 27, 2023
@viktorrusakov viktorrusakov merged commit fc90b3f into openedx:master Dec 29, 2023
10 checks passed
@openedx-semantic-release-bot

🎉 This PR is included in version 21.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Husky precommit hook doesn't work
4 participants