-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added linter for JSON files #3330
base: release-23.x
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
15406d6
to
8d3f434
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-23.x #3330 +/- ##
=============================================
Coverage 93.91% 93.91%
=============================================
Files 232 232
Lines 3943 3943
Branches 933 901 -32
=============================================
Hits 3703 3703
Misses 236 236
Partials 4 4 ☔ View full report in Codecov by Sentry. |
8d3f434
to
4a55c6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM! I am curious as to if we want to go the "lint everthing unless we ignore it" route or if we'd rather update the files: ['**/*.json'],
in .eslintrc.js
to be more specific.
I'm happy with this as-is though!
I think that the "lint everthing unless we ignore it" approach suits us. We have some files in JSON format that do not belong to the tokens folder and now they are also subject to the linter rules. |
4a55c6f
to
48ed59d
Compare
✅ Deploy Preview for paragon-openedx-v23 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Description
With the advent of design tokens, a large number of new JSON files have appeared in Paragon. This PR provides an extended configuration of the JSON file linter, including formatting, checking for duplicate keys, etc.
Merge Checklist
example
app?Post-merge Checklist