feat(semantic-release): implement semantic release #72
Conversation
|
I implemented I was able to trigger a release which had tags from Travis-CI ...only thing is (of course there's at least one thing)
|
| directories: | ||
| - ~/.npm | ||
|
|
||
| notifications: |
There was a problem hiding this comment.
There are also HipChat notifications that we should implement later (I just didn't have the HipChat authentication information)
Pull Request Build Completed As Expected
|
|
FYI @michaelroytman let me know if you have any questions about how this works! |
arizzitano
left a comment
arizzitano
left a comment
There was a problem hiding this comment.
👍 Let's get this merged so we can start seeing it in action!
| - arizzitano@edx.org | ||
| - jbradley@edx.org | ||
| on_success: always | ||
| on_failure: always |
There was a problem hiding this comment.
I figure we can adjust this once we get a feel for the notification emails and have ironed out any kinks.
Side question: do you know whether there's a way to send build failure emails to the person who merged the PR? Not a requirement for this PR (actually probably should go in a separate one) but a nice-to-have for the future.
| "deploy-storybook": "storybook-to-ghpages", | ||
| "lint": "eslint --ext .js --ext .jsx .", | ||
| "precommit": "npm run lint", | ||
| "commit": "git-cz", |
There was a problem hiding this comment.
What's the expected behavior of this hook? I just did a test commit and it appeared to run but didn't seem to do anything. Do contributors need to install and run cz-cli locally?
There was a problem hiding this comment.
Discussed in person; we will address this in a follow-on PR.
installed semantic-release package, added commit convential commit analyzer, updated travis yaml to run semantic release after build success fix(travis): add node 8 to travis configuration fix(dependency): Missing @storybook/channels dependency that was causing build failures on Node 8
jaebradley
force-pushed
the
implement-semantic-release
branch
from
652066d to
8de3944
Compare
Implementation Details
travis.ymlto runsemantic-releaseafter build successsemantic-releaseat least one Travis build must be Node 8+. This doesn't seem to be a big issue for this project - there was one package I needed to install (@storybook/channels) in order to get the Node 8 build completing successfullyExample Commit Process (
npm run commit)