Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARCHBOM-1475: Added ability to name metadata output file #58

Merged
merged 5 commits into from
Nov 3, 2020

Conversation

jinder1s
Copy link
Contributor

@jinder1s jinder1s commented Nov 2, 2020

Previously, there was no way to change the file to which metadata was written. This PR adds this ability.

@jinder1s
Copy link
Contributor Author

jinder1s commented Nov 2, 2020

Should the version for this be 2.1.0 instead of 2.0.4? This PR adds functionality, but you could say it should have been that way already. so this can also be a bug fix

@jinder1s jinder1s changed the title Added ability to name metadata output file ARCHBOM-1475: Added ability to name metadata output file Nov 2, 2020
Copy link
Contributor

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go for 2.1.0 since it's a feature addition.

(Also, should have a changelog entry.)

@jinder1s jinder1s merged commit 49f97cb into master Nov 3, 2020
@jinder1s jinder1s deleted the msingh/improve/metadata branch November 3, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants