Skip to content

Commit

Permalink
fix: replace deprecated github actions (#533)
Browse files Browse the repository at this point in the history
* fix: replace deprecated github actions
---------

Co-authored-by: Usama Sadiq <usama.sadiq@arbisoft.com>
  • Loading branch information
huniafatima-arbi and UsamaSadiq authored Jul 23, 2024
1 parent e680341 commit 117741a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion edx_repo_tools/pull_request_creator/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ def _create_new_pull_request(self):
if self.output_pr_url_for_github_action:
# using print rather than logger to avoid the logger
# prepending anything past which github actions wouldn't parse
print(f'::set-output name=generated_pr::https://github.com/{self.repository.full_name}/pull/{pr.number}')
print(f'generated_pr=https://github.com/{self.repository.full_name}/pull/{pr.number} >> $GITHUB_OUTPUT')

def delete_old_pull_requests(self):
logger.info("Checking if there's any old pull requests to delete")
Expand Down
2 changes: 1 addition & 1 deletion tests/test_pull_request_creator.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def test_outputs_url_on_success(self, print_mock, create_branch_mock, create_pr_
assert print_mock.call_count == 1
found_matching_call = False
for call in print_mock.call_args_list:
if 'set-output' in call.args[0]:
if '$GITHUB_OUTPUT' in call.args[0]:
found_matching_call = True
assert found_matching_call

Expand Down

0 comments on commit 117741a

Please sign in to comment.