feat: Add a new check to ensure no teams have admin or maintain access. #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feanil
force-pushed
the
feanil/disable_admin
branch
from
c9743d6 to
d546446
Compare
feanil
force-pushed
the
feanil/disable_admin
branch
from
d546446 to
7952f25
Compare
arbrandes
approved these changes
Mar 8, 2024
| class EnsureNoAdminOrMaintainTeams(Check): | ||
| """ | ||
| Teams should not be granted `admin` or `maintain` access to a repository unless the access | ||
| is exceptions and it is noted here. All other `admin` and `maintain` access is downgraded to |
There was a problem hiding this comment.
Suggested change
| is exceptions and it is noted here. All other `admin` and `maintain` access is downgraded to | |
| is an exception and it is noted here. All other `admin` and `maintain` access is downgraded to |
Not sure if you meant "in exceptions" or just missed an "an".
For each repo, the check will find any teams that have admin or maintain access to that repo and downgrade the access of the team to write.
feanil
force-pushed
the
feanil/disable_admin
branch
from
7952f25 to
baf310a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each repo, the check will find any teams that have admin or maintain
access to that repo and downgrade the access of the team to write.