feat!: Python 3.12 Upgrade #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsamaSadiq
commented
Sep 11, 2024
| SkillValidationConfiguration with both course and organization. | ||
| """ | ||
| with pytest.raises(IntegrityError) as raised_exception: | ||
| with pytest.raises(ValidationError) as raised_exception: |
There was a problem hiding this comment.
Django 4.2 raises ValidationError before reaching to the point where IntegrityError is raised since the model's full_clean() method is catching this issue before database-level integrity checks can be enforced.
There was a problem hiding this comment.
I think this needs some manual verification? I will find some time to test this on my end.
UsamaSadiq
force-pushed
the
python312-upgrade
branch
from
0deb4f2
to
44d2364
Compare
| @@ -15,6 +15,6 @@ | |||
| # 2. MINOR version when you add functionality in a backwards compatible manner, and | |||
| # 3. PATCH version when you make backwards compatible bug fixes. | |||
| # More details can be found at https://semver.org/ | |||
| __version__ = '1.53.0' | |||
| __version__ = '1.54.0' | |||
There was a problem hiding this comment.
@UsamaSadiq Should we bump this to 2.0.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python 3.12env onlyPython 3.12envPython<3.12numpy,pandaspackages to latest versions forPython 3.12support.1.54.0.Testing
Python 3.12are green.