Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include current day in instructor dashboard (FC-0024) #260

Merged

Conversation

SoryRawyer
Copy link
Contributor

This addresses #246. The query for fact_enrollments_by_day is also updated to extend the current enrollment status window to tomorrow so that the current days' enrollment status is included, which in turn makes the enrollment status available for the chart. In that same query, I've also confirmed that the call to lagInFrame provides a default value and so the call to coalesce further down is not needed.

This addresses openedx#246. The query for `fact_enrollments_by_day` is also
updated to extend current enrollment status to tomorrow so that the
current days' enrollment status is included, which in turn makes the
enrollment status available for the chart.
@SoryRawyer
Copy link
Contributor Author

I realize now that the commit message/PR title uses feat but references an issue that starts with bug. Please let me know if it'd be better to amend the commit/PR title to use fix instead.

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks. No worries about the commit message.

@bmtcril bmtcril merged commit 9cce99a into openedx:main Aug 3, 2023
5 checks passed
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 3, 2023
@openedx-webhooks
Copy link

Although this pull request is already merged, I'm still watching it for updates.

There is nothing you have to do. No action is needed from your side. Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants