feat: include current day in instructor dashboard (FC-0024) #260
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses openedx#246. The query for `fact_enrollments_by_day` is also updated to extend current enrollment status to tomorrow so that the current days' enrollment status is included, which in turn makes the enrollment status available for the chart.
|
I realize now that the commit message/PR title uses |
bmtcril
approved these changes
Aug 3, 2023
openedx-webhooks
added
the
open-source-contribution
|
Although this pull request is already merged, I'm still watching it for updates. There is nothing you have to do. No action is needed from your side. Thanks again for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #246. The query for
fact_enrollments_by_dayis also updated to extend the current enrollment status window to tomorrow so that the current days' enrollment status is included, which in turn makes the enrollment status available for the chart. In that same query, I've also confirmed that the call tolagInFrameprovides a default value and so the call tocoalescefurther down is not needed.