-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use dbt models for problem datasets #272
Conversation
Converts `fact_problem_responses` and `fact_learner_problem_summary` from virtual to physical datasets, relying on models created by dbt.
Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, v1.3 of aspects-dbt is released with the prerequisite changes.
Gah, sorry, this is blocked by a bug in the dbt project. I'll put this back into draft status until I can open a new PR to the dbt project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Just a heads up, there are big changes to multi-response problems coming down in the somewhat near term. Shouldn't impact this PR right now. They're going to be something of a pain to model, but it seems like the only way to correctly capture those problems: openedx/event-routing-backends#325
@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Converts
fact_problem_responses
andfact_learner_problem_summary
from virtual to physical datasets, relying on models created by dbt. Relies on changes in the corresponding aspects-dbt PR. If and when those changes get approved I will mark this PR as ready to review.