Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add student role with minimal access in Superset #307

Merged
merged 7 commits into from
Aug 25, 2023
Merged

feat: Add student role with minimal access in Superset #307

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e678c51
feat: defining student rol
nandodev-net Aug 17, 2023
6b81a55
fix: student and instructor permissions template and some student rol…
nandodev-net Aug 21, 2023
ba8439b
fix: Jinja correction
nandodev-net Aug 21, 2023
850199f
fix: read_only_permission.json created and operator included in langu…
nandodev-net Aug 22, 2023
ca11c10
fix: removing config.yml
nandodev-net Aug 22, 2023
bd79be8
fix: remove default role
Ian2012 Aug 23, 2023
ab56715
fix: Add check to prevent student role access when SUPERSET_BLOCK_STU…
nandodev-net Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tutoraspects/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@
"instructor": "Instructor",
"operator": "Operator",
"admin": "Admin",
"student": "Student",
},
),
("SUPERSET_ADMIN_EMAIL", "admin@openedx.org"),
Expand Down
8 changes: 5 additions & 3 deletions tutoraspects/templates/aspects/apps/superset/pythonpath/openedx_sso_security_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,11 @@ def _get_user_roles(self, username, language):
return ["instructor", f"instructor-{language}"]
else:
roles = self.extra_get_user_roles(username, decoded_access_token)
if bool("{{SUPERSET_BLOCK_STUDENT_ACCESS}}") and not roles:
raise Exception(f"Student {username} tried to access Superset")
return roles if roles else []
if roles:
return roles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm somewhat concerned about this logic. Having a student role returned here would override SUPERSET_BLOCK_STUDENT_ACCESS. Maybe not a big deal, but can we add a check for that and throw an exception if it happens?

if not bool("{{SUPERSET_BLOCK_STUDENT_ACCESS}}"):
return ["student", f"student - {language}"]
Ian2012 marked this conversation as resolved.
Show resolved Hide resolved
raise Exception(f"Student {username} tried to access Superset")

def extra_get_user_roles(self, username, decoded_access_token):
"""
Expand Down
2 changes: 2 additions & 0 deletions tutoraspects/templates/aspects/apps/superset/pythonpath/superset_config_docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,14 @@
"alpha": ["Alpha"], # Global staff
"gamma": ["Gamma"], # Course staff
"instructor": ["{{SUPERSET_ROLES_MAPPING.instructor}}"], # Course instructors
"student": ["{{SUPERSET_ROLES_MAPPING.student}}"], # Course students
"operator": ["{{SUPERSET_ROLES_MAPPING.operator}}"], # Installation operators
"public": ["Public"], # AKA anonymous users
}

for language in LANGUAGES.keys():
AUTH_ROLES_MAPPING[f"instructor-{language}"] = [f"{{SUPERSET_ROLES_MAPPING.instructor}} - {language}"]
AUTH_ROLES_MAPPING[f"student-{language}"] = [f"{{SUPERSET_ROLES_MAPPING.student}} - {language}"]
Ian2012 marked this conversation as resolved.
Show resolved Hide resolved


from openedx_sso_security_manager import OpenEdxSsoSecurityManager
Expand Down
Loading
Loading