The new MFE payment flow does not support custom payment processors

[davidjoy]

Hi all,

@sambapete had outlined some very valid issues with the payment MFE as it exists today in this issue: #67 (comment)

After having a discussion at our team's standup (with @sarina @nedbat and @stvstnfrd), we were wondering if the right course of action for Lilac is to revive and support the non-MFE payment flow that was deprecated, since the MFE effectively hasn't attained feature parity yet.

Unfortunately, none of us who were talking about it were particularly familiar with what that old flow was and how much of it is deprecated and/or removed.

Can anyone enlighten us and provide some links, and then maybe we can all make a decision about adding support for it back in?

[sambapete]

You could always take a look at what I had to do in our fork of lilac.master to see what I did. I am sorry, it's not that well documented, but most of my changes are centered around these 3 commits EDUlib/edx-platform@e964d8d EDUlib/edx-platform@72f4798 EDUlib/edx-platform@01affd9 There are a lot of files involved, but some of them are just copies of the same file with or without what I had before Lilac and what came with Lilac. As I previously said, there are modifications I made by looking at the code that was in Koa versus the code that was in Lilac. It also involves modifications that were made to the verification process. Especially calling the Profile MFE to get the status of a user's identity validation. In the end, I am able to use our payment processor but it might now have been tested perfectly. I was able to buy a course upon registration, upgrading to verified status after being in audit, and even registering through the about page. Those were the 3 test cases I was concerned with. These modifications were made only in Lilac. Previous modifications to our payment processor (netbanx / paysafe) were made a long time ago in our fork of ecommerce https://github.com/EDUlib/ecommerce/tree/edulib-lilac.master A few changes here and there because it is an hosted page solution, but it has been working since 2016. I can't remember if it was with Cypress our Dogwood. The processor code (largely based on cybersource.py) is available at https://github.com/EDUlib/ecommerce/blob/edulib-lilac.master/ecommerce/extensions/payment/processors/paysafe.py I even had to integrate their SDK in our fork in order to simplify the installation from release to release https://github.com/EDUlib/ecommerce/tree/edulib-lilac.master/ecommerce/Paysafe If you have any questions, do not hesitate. Le jeu. 20 mai 2021, à 13 h 46, David Joy ***@***.***> a écrit :

…

Hi all, @sambapete <https://github.com/sambapete> had outlined some very valid issues with the payment MFE as it exists today in this issue: #67 (comment) <#67 (comment)> After having a discussion at our team's standup (with @sarina <https://github.com/sarina> @nedbat <https://github.com/nedbat> and @stvstnfrd <https://github.com/stvstnfrd>), we were wondering if the right course of action for Lilac is to revive and support the non-MFE payment flow that was deprecated, since the MFE effectively hasn't attained feature parity yet. Unfortunately, none of us who were talking about it were particularly familiar with what that old flow *was* and how much of it is deprecated and/or removed. Can anyone enlighten us and provide some links, and then maybe we can all make a decision about adding support for it back in? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#74>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACD6PLPYWWDPDOLIVE6TLJLTOVDHDANCNFSM45HQY6QQ> .

-- Salutations / Regards , Pierre Mailhot, M.Sc., CISSP 514-916-9558

[sambapete]

With regards to changes that were made to the ID Verification process that might also have had an impact on the Payment MFE behavior. https://discuss.openedx.org/t/deprecation-removal-id-verification-flow-in-edx-platform/3521 I had commented on it back then. I am just mentioning it in case it could be useful. Le jeu. 20 mai 2021, à 14 h 35, Pierre Mailhot ***@***.***> a écrit :

…

You could always take a look at what I had to do in our fork of lilac.master to see what I did. I am sorry, it's not that well documented, but most of my changes are centered around these 3 commits EDUlib/edx-platform@e964d8d EDUlib/edx-platform@72f4798 EDUlib/edx-platform@01affd9 There are a lot of files involved, but some of them are just copies of the same file with or without what I had before Lilac and what came with Lilac. As I previously said, there are modifications I made by looking at the code that was in Koa versus the code that was in Lilac. It also involves modifications that were made to the verification process. Especially calling the Profile MFE to get the status of a user's identity validation. In the end, I am able to use our payment processor but it might now have been tested perfectly. I was able to buy a course upon registration, upgrading to verified status after being in audit, and even registering through the about page. Those were the 3 test cases I was concerned with. These modifications were made only in Lilac. Previous modifications to our payment processor (netbanx / paysafe) were made a long time ago in our fork of ecommerce https://github.com/EDUlib/ecommerce/tree/edulib-lilac.master A few changes here and there because it is an hosted page solution, but it has been working since 2016. I can't remember if it was with Cypress our Dogwood. The processor code (largely based on cybersource.py) is available at https://github.com/EDUlib/ecommerce/blob/edulib-lilac.master/ecommerce/extensions/payment/processors/paysafe.py I even had to integrate their SDK in our fork in order to simplify the installation from release to release https://github.com/EDUlib/ecommerce/tree/edulib-lilac.master/ecommerce/Paysafe If you have any questions, do not hesitate. Le jeu. 20 mai 2021, à 13 h 46, David Joy ***@***.***> a écrit : > Hi all, > > @sambapete <https://github.com/sambapete> had outlined some very valid > issues with the payment MFE as it exists today in this issue: #67 > (comment) > <#67 (comment)> > > After having a discussion at our team's standup (with @sarina > <https://github.com/sarina> @nedbat <https://github.com/nedbat> and > @stvstnfrd <https://github.com/stvstnfrd>), we were wondering if the > right course of action for Lilac is to revive and support the non-MFE > payment flow that was deprecated, since the MFE effectively hasn't attained > feature parity yet. > > Unfortunately, none of us who were talking about it were particularly > familiar with what that old flow *was* and how much of it is deprecated > and/or removed. > > Can anyone enlighten us and provide some links, and then maybe we can all > make a decision about adding support for it back in? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#74>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACD6PLPYWWDPDOLIVE6TLJLTOVDHDANCNFSM45HQY6QQ> > . > -- Salutations / Regards , Pierre Mailhot, M.Sc., CISSP 514-916-9558

-- Salutations / Regards , Pierre Mailhot, M.Sc., CISSP 514-916-9558

[sambapete]

I was trying to better understand how the Payment MFE works in order maybe to see if I can find a way to use our current payment processor (Paysafe).

I found this in ecommerce/docs/decisions/0005-payment-microfrontend-support-and-bff-apis.rst

As of 8/2019, the initial implementation of the Payment MFE no longer allows the payment processors to be pluggable on the frontend. This can be revisited when and if necessary.

Does this mean that we were supposed to know that other payment processors would not be supported by the Payment MFE way back in 2019, almost 2 years ago?

I have to be honest, that went straight over my head if this was the case... I am not sure who caught this in the rest of the community.

[tabrezgoilkar]

what is advise on payment gateway issue? I have fresh installation of Lilac and planned go live was supposed to be Oct 2nd week, but i am stuck with Payment gateway issue? shall i revert back and Use Koa version or shall i wait for maple release to use code from it? or use shopping cart? as this is affecting my go live dates appreciate your feedback