Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setup.py update using script #56

Merged
merged 2 commits into from
Sep 6, 2023
Merged

fix: setup.py update using script #56

merged 2 commits into from
Sep 6, 2023

Conversation

edx-requirements-bot
Copy link
Contributor

Updated repo with setup.py changes for package extras, for more context please have a look into this issue

bmtcril
bmtcril approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking I don't think those imports are used here, but it's not failing checks so I'll merge it.

@bmtcril bmtcril merged commit b964cfb into main Sep 6, 2023
@bmtcril bmtcril deleted the jenkins/zshkoor/setup-py-updated-e520ec6 branch September 6, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmtcril bmtcril bmtcril approved these changes

@zubairshakoorarbisoft zubairshakoorarbisoft Awaiting requested review from zubairshakoorarbisoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edx-requirements-bot @bmtcril