Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: python upgrade now clones testeng-ci from its actual github lo… #247

Closed
wants to merge 1 commit into from

Conversation

bszabo
Copy link
Contributor

@bszabo bszabo commented Oct 18, 2022

This is in response to a github alert to the effect that the weekly python upgrade job for this repo was failing.

Learned from Jeremy Bowman that this error is an instance of a handful of repos that had their python upgrade scripts corrupted by an automated URL update job. This is a one-line fix to restore the reference to the testeng-ci dependency to its correct home (edx, not openedx).

…cation (edx)

was inadvertently broken earlier in a prior URL update action
@bszabo bszabo requested review from sarina and connorhaugh October 18, 2022 21:21
@bszabo
Copy link
Contributor Author

bszabo commented Oct 19, 2022

I'm surprised to see that this change reduced coverage for the project, and am looking at how to remedy this. I'll post a follow-up commit once I've figured it out. No review necessary/appropriate yet.

@sarina
Copy link
Contributor

sarina commented Oct 19, 2022

Approved, but it would be superior for this workflow to use https://github.com/openedx/.github/blob/master/workflow-templates/upgrade-python-requirements.yml

@UsamaSadiq
Copy link
Member

Change already merged in the PR #249 so this PR is not needed anymore.

@feanil feanil closed this Jun 26, 2023
@feanil feanil deleted the bszabo/python-upgrade-workflow branch June 26, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants