Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bok-choy usage #322

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Remove bok-choy usage #322

merged 7 commits into from
Oct 20, 2023

Conversation

salman2013
Copy link
Contributor

@salman2013 salman2013 commented Oct 16, 2023

Description

As the bok-choy has been deprecated openedx/public-engineering#13, we are removing its usage from the code in this PR.

Ticket : https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=40710452

@salman2013 salman2013 requested a review from a team October 17, 2023 04:42
@salman2013 salman2013 changed the title chore: remove bok-choy Remove bok-choy usage Oct 17, 2023
@salman2013 salman2013 marked this pull request as ready for review October 17, 2023 04:45
Copy link
Contributor

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 point, rest seems good

requirements/test.in Show resolved Hide resolved
@salman2013 salman2013 requested a review from farhan October 18, 2023 15:17
@farhan
Copy link
Contributor

farhan commented Oct 18, 2023

@salman2013 Did you try removing the following code and its relevance from the ci.yml. I think it's only related to integration tests.

    - name: Set up test environment
      run: |
        sudo apt-get install xvfb
        wget https://github.com/mozilla/geckodriver/releases/download/v0.15.0/geckodriver-v0.15.0-linux64.tar.gz
        mkdir geckodriver
        tar -xzf geckodriver-v0.15.0-linux64.tar.gz -C geckodriver
        export PATH=$PATH:$(pwd)/geckodriver
        export BOTO_CONFIG=/dev/null

Copy link
Contributor

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should replace following
run: xvfb-run --server-args=-ac -- tox -e ${{ matrix.toxenv }}
with
run: tox -e ${{ matrix.toxenv }}

@salman2013 salman2013 merged commit 5258424 into master Oct 20, 2023
4 of 5 checks passed
@salman2013 salman2013 deleted the salman/remove-bok-choy branch October 20, 2023 09:05
@feanil feanil mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants