-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bok-choy usage #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 point, rest seems good
@salman2013 Did you try removing the following code and its relevance from the - name: Set up test environment
run: |
sudo apt-get install xvfb
wget https://github.com/mozilla/geckodriver/releases/download/v0.15.0/geckodriver-v0.15.0-linux64.tar.gz
mkdir geckodriver
tar -xzf geckodriver-v0.15.0-linux64.tar.gz -C geckodriver
export PATH=$PATH:$(pwd)/geckodriver
export BOTO_CONFIG=/dev/null
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should replace following
run: xvfb-run --server-args=-ac -- tox -e ${{ matrix.toxenv }}
with
run: tox -e ${{ matrix.toxenv }}
Description
As the bok-choy has been deprecated openedx/public-engineering#13, we are removing its usage from the code in this PR.
Ticket : https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=40710452