Merged
Conversation
a314052 to
f9c2e59
Compare
f9c2e59 to
5f7781c
Compare
pkulkark
reviewed
Jan 2, 2023
pkulkark
reviewed
Jan 2, 2023
pkulkark
reviewed
Jan 2, 2023
pkulkark
reviewed
Jan 3, 2023
pkulkark
reviewed
Jan 4, 2023
pkulkark
approved these changes
Jan 4, 2023
Contributor
pkulkark
left a comment
There was a problem hiding this comment.
@navinkarkera Just the couple of nits noted, otherwise LGTM 👍
- I tested this: verified that the skill verification pipeline works and UI is displayed correctly, as described in the testing instructions
- I read through the code
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Injects form to allow users verify skills/tags related to vertical block.
JIRA:
Private-refBB-6999Dependencies:
Testing instructions:
This assumes you are testing this on a devstack.
<devstack_base_dir>/src/and checkout this branch.make frontend-app-learning-up lms-up studio-up discovery-upmake lms-shell.pip install -e /src/xblock-skill-taggingprivate.pyfile inlms/envs/and add the following settings:make lms-restart<devstck_dir>/src/make discovery-shelland cd intotaxonomy-connectorin/edx/src/Sandbox
Details
Reviewers:
Merge checklist:
Post merge:
finished.