android-tools: Fix inconsistency between selinux configurations #866
Conversation
I hoped that mentioning it once should be enough. |
|
Not to mention that there is no inconsistency before #862 gets merged. This commit should be a part of that pull request rather than a separate one. |
|
@lumag Do you want me to mention both Reported-by And Signed-off-by? |
|
@quic-raghuvar huh? Reported-by is for me reporting the issue. Signed-off-by shows another fact about the patch author. Have you read what does it actually mean? |
ConditionPathExists is set to /etc/usb-debugging-enabled as part of meta-oe/ recipes-devtools/android-tools/android-tools/android-tools-adbd.service file. However, in meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/ android-tools/android-tools-adbd.service file ConditionPathExists is set to /var/usb-debugging-enabled This causes an internal inconsistency between selinux-enabled and -disabled configurations. Hence, change ConditionPathExists=/var/usb-debugging-enabled to ConditionPathExists=/etc/usb-debugging-enabled Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Raghuvarya S <quic_raghuvar@quicinc.com>
quic-raghuvar
force-pushed
the
patch-6
branch
from
84474b9 to
75c3590
Compare
|
And the Author field is an internal git metadata. Due to .git misconfiguration on your side you have your account name written there. Please make sure to fix the configuration on your side then use a special argument of If you are using the GitHub's web interface, please stop doing that. It might end up in different kinds of the issues, incuding, but not limited to metadata, whitespaces, etc. And by using web interface you are not testing your changes. |
You didn't answer. Have you read what does Signed-off-by signify? |
|
Some sources mentioned to add signed-off-by for DCO. |
|
What is DCO? You didn't add it beforehand, that's why I'm trying to make sure that you understand it. |
ConditionPathExists is set to /etc/usb-debugging-enabled as part of meta-oe/ recipes-devtools/android-tools/android-tools/android-tools-adbd.service file. However, in meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/ android-tools/android-tools-adbd.service file ConditionPathExists is set to /var/usb-debugging-enabled This causes an internal inconsistency between selinux-enabled and -disabled configurations. Hence, change ConditionPathExists=/var/usb-debugging-enabled to ConditionPathExists=/etc/usb-debugging-enabled Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Raghuvarya S <quic_raghuvar@quicinc.com>
|
Okay. I uploaded a new commit with no line space between tags. Also, I guess it got merged hence, turned out to be a new commit. |
|
No, it wasn't merged. Please use |
|
@quic-raghuvar any updates for these patches? This can not be merged as it is now. |
ConditionPathExists is set to /etc/usb-debugging-enabled as part of meta-oe/ recipes-devtools/android-tools/android-tools/android-tools-adbd.service file. However, in meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/ android-tools/android-tools-adbd.service file ConditionPathExists is set to /var/usb-debugging-enabled
This causes an internal inconsistency between selinux-enabled and -disabled configurations.
Hence, change ConditionPathExists=/var/usb-debugging-enabled to ConditionPathExists=/etc/usb-debugging-enabled
Reported-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org