Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Fix questionnaire_assessments to not php die if there is a form problem. #6677

Closed
adunsulag opened this issue Jul 21, 2023 · 2 comments · Fixed by #6678
Closed

bug: Fix questionnaire_assessments to not php die if there is a form problem. #6677

adunsulag opened this issue Jul 21, 2023 · 2 comments · Fixed by #6678
Assignees
@adunsulag
Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Milestone
7.0.2

Comments

@adunsulag
Copy link
Member

The questionnaire_assessments does a php die() if it hits the "Nothing to report" line. This should spit out an error but not halt the php thread if there's a problem. As part of this work we should make sure the forms.php process does not die if a form is implemented improperly by not having a reports.php page setup properly.
@adunsulag adunsulag self-assigned this Jul 21, 2023
@sjpadgett
Copy link
Member

Problem is nothing to report it’s not an error. Throw an exception should percolate all the way to the UI If I remember right

@adunsulag
Copy link
Member Author

Right now if there is a form created after a questionnaire that has the 'nothing to report' that subsequent form is skipped because the php process dies. Just running through the style formatter check and will push so you can see what I did here.

adunsulag added a commit to DiscoverAndChange/openemr that referenced this issue Jul 21, 2023
@adunsulag
Fixes openemr#6677 Questionnaire die fix
76d16e2 
Fixes openemr#6677.  Dieing in the questionnaire report kills other forms that
want to render.  We shouldn't allow that to happen.  We catch exceptions
in the forms and log them so that other forms can continue to render.
@adunsulag adunsulag mentioned this issue Jul 21, 2023
Merged
adunsulag added a commit that referenced this issue Jul 27, 2023
@adunsulag
Fixes #6677 Questionnaire die fix (#6678)
1596ef0 
Fixes #6677.  Dieing in the questionnaire report kills other forms that
want to render.  We shouldn't allow that to happen.  We catch exceptions
in the forms and log them so that other forms can continue to render.
@adunsulag adunsulag added this to the 7.0.2 milestone Nov 16, 2023
@adunsulag adunsulag added the developers This issue targets an issue that is for developers/collaborators/module writers/technical users label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adunsulag adunsulag

Labels
developers This issue targets an issue that is for developers/collaborators/module writers/technical users
Projects
None yet
Milestone
7.0.2
Development

Successfully merging a pull request may close this issue.

Fixes #6677 Questionnaire die fix DiscoverAndChange/openemr
2 participants
@adunsulag @sjpadgett