Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: menu tab with iframe of external domain shows loading overlay even after iframe has loaded #6781

Closed
adunsulag opened this issue Aug 21, 2023 · 0 comments · Fixed by #6782
Milestone

Comments

@adunsulag
Copy link
Member

In our menu tabs if you have a menu item that is to an external domain, the main screen window will show an overlay that has "Loading

..." even after the iframe has loaded. It also shows in the tab the loading spinner giving the user the impression that data is still loading.

This comes into play if we have a registered smart app as a menu item that most often will be on an external domain.

adunsulag added a commit to DiscoverAndChange/openemr that referenced this issue Aug 21, 2023
Fixed the menu item to hide the overlay on the external domain.

I still don't like that it sets the title to unknown but without some
heavier refactoring to populate a default label as defined in the menu
system there's not a lot that can be done here.

Fixes openemr#6781
adunsulag added a commit that referenced this issue Aug 22, 2023
Fixed the menu item to hide the overlay on the external domain.

I still don't like that it sets the title to unknown but without some
heavier refactoring to populate a default label as defined in the menu
system there's not a lot that can be done here.

Fixes #6781
@adunsulag adunsulag added this to the 7.0.2 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant