fix: fix AllergyIntoleranceService lookup by pid to return results instead of empty list. #6864
Conversation
stephenwaite
changed the title
| if (isset($search['lists.pid'])) { | ||
| $search['puuid'] = $search['lists.pid']; | ||
| $patient = (new PatientService())->findByPid($search['lists.pid']); | ||
| $search['puuid'] = UuidRegistry::uuidToString($patient['uuid']); |
There was a problem hiding this comment.
nice!
@adunsulag , is there a chance this fix may unmask a bug and affect inferno testing?
There was a problem hiding this comment.
Yes @stephenwaite and @bradymiller, I'll need to look at this more closely as I thought we brought in a PR recently to 'supposedly' fix the very thing that @stephenwaite is fixing. I'm finding it odd that its still braking. I've got some stuff going on today, but will see if I can get to it this evening or tomorrow.
There was a problem hiding this comment.
@stephenwaite I opened a PR to your PR with some changes. I thought the changes by @IvanJov
were in this same spot but it was lower down in the function. I tested this and allergies are now showing up in the card. Sinces its hitting the lists.pid field for the search it shouldn't have an impact on the Inferno testing.
Here is the PR. stephenwaite#9
Rather than doing a duplicate query, we filter on the patient_id for the pid in the query.
…service-getall-pid Fix search by lists.pid and remove dup query
|
thanks @adunsulag and @bradymiller! |
|
|
adunsulag
changed the title
adunsulag
added
the
developers
Fixes #
Short description of what this resolves:
Changes proposed in this pull request: