Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow ups to GhostCat - AJP connector #1583

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

cbeach47
Copy link
Contributor

#1533

Checklist
Description of change

2020.1.0 included tomcat 8.5.51 , and subsequently broke the AJP connector.

This PR fixes the AJP connector with the following:
mandatory-config.properties :
ajp.secret.required - it should be set to false for now. Default is true since it's more secure
ajp.address - Default is 127.0.0.1

Another configuration, ajp.secret , was added in, but should be considered a beta feature. The default value ignore of ajp.secret will do just that.

I am waiting to test ajp.secret until httpd 2.4.42+ is released into the repos - currently looks like it doesn't have full approval of the community. It would be appreciated if folks in the community can confirm ajp.secret works with a different web server, and then ajp.secret can move out of beta.

Support for ajp secret in httpd 2.4.42 : https://www.apachelounge.com/viewtopic.php?t=8448
Issues with 2.4.42 / 2.4.43 : https://www.apachelounge.com/viewtopic.php?t=8441

@cbeach47 cbeach47 requested a review from edalex-ian March 26, 2020 15:25
Copy link
Member

@edalex-ian edalex-ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this mostly - hence approve. But not sure what you're doing with the version there.

Also, how do you plan to capture the doco for this? I note that most of these are also missing from mandatory and optional properties, so I guess it's just something over on openequella.github.io. 🤔

build.sbt Outdated Show resolved Hide resolved
@cbeach47
Copy link
Contributor Author

Thx @edalex-ian - The AlphaC was not supposed to be committed, so I switched it back to Alpha. For the configs, due to the minutes in https://github.com/openequella/openEQUELLA/wiki/CDM-2019-12 , I've separated out the documented configs and added the configs from this PR in openequella/openequella.github.io#65 . Once the builds pass, I'll merge this in.

@edalex-ian
Copy link
Member

Good stuff! Merge on. 👍

@cbeach47 cbeach47 merged commit 9a05416 into openequella:develop Mar 31, 2020
@cbeach47 cbeach47 deleted the bugfix/1533-ajp-connector branch March 31, 2020 03:00
PenghaiZhang pushed a commit that referenced this pull request Mar 31, 2020
* #1533 Added in ajp.secret and ajp.secret.required
PenghaiZhang pushed a commit that referenced this pull request Mar 31, 2020
* #1533 Added in ajp.secret and ajp.secret.required
PenghaiZhang pushed a commit that referenced this pull request Apr 1, 2020
* #1533 Added in ajp.secret and ajp.secret.required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants