Change styles to allow SettingsListControl to support wider controls #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such as Sliders, for the Search boosting settings.
mrblippy
approved these changes
Apr 15, 2020
edalex-ian
reviewed
Apr 15, 2020
Source/Plugins/Core/com.equella.core/js/tsrc/components/SettingsListControl.tsx
Outdated
Show resolved
Hide resolved
edalex-ian
approved these changes
Apr 20, 2020
nmkae
approved these changes
Apr 20, 2020
Comment on lines
+33
to
+36
| secondaryAction: { | ||
| width: "55%", | ||
| display: "flex", | ||
| justifyContent: "flex-end" |
There was a problem hiding this comment.
A bit odd with the widths and flexbox, I'd expect flexbox grow to negate the need for doing widths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such as Sliders, for the Search boosting settings.
Checklist
Description of change
The amount of space dedicated to the ListItemSecondaryAction was prohibitively small - works great for things like checkboxes, but squashes wide components such as sliders. This PR changes this so there is much more room to work with.
Note: The slider item in the list isn't a change, simply a visual example of this change working with a wide component.
Also - add stories for the SettingsListControl.