Contribution wizard lost metadata fix #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure metadata attributed to hidden pages is not wiped by the mandatory field check.
edalex-ian
approved these changes
May 7, 2020
Source/Plugins/Core/com.equella.core/src/com/tle/web/wizard/section/RootWizardSection.java
Outdated
Show resolved
Hide resolved
Co-authored-by: edalex-ian <43919233+edalex-ian@users.noreply.github.com>
ChristianMurphy
approved these changes
May 7, 2020
5 tasks
SammyIsConfused
added a commit
to SammyIsConfused/openEQUELLA
that referenced
this pull request
May 14, 2020
…ost_metadata_due_to_mandatory_fields Contribution wizard lost metadata fix
SammyIsConfused
added a commit
to SammyIsConfused/openEQUELLA
that referenced
this pull request
May 14, 2020
…ost_metadata_due_to_mandatory_fields Contribution wizard lost metadata fix
SammyIsConfused
added a commit
that referenced
this pull request
May 15, 2020
…a_due_to_mandatory_fields Contribution wizard lost metadata fix
SammyIsConfused
added a commit
that referenced
this pull request
May 15, 2020
…a_due_to_mandatory_fields Contribution wizard lost metadata fix
SammyIsConfused
added a commit
that referenced
this pull request
May 15, 2020
…a_due_to_mandatory_fields Contribution wizard lost metadata fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure metadata attributed to hidden pages is not wiped by the
mandatory field check.
Checklist
Description of change
#1678
The lost metadata was caused by the mandatory fields check - it would initialize all pages of a wizard. Since wizards can have visibility scripting, this caused issues with hidden pages initializing when they shouldn't, which wipes their metadata.
Surrounding this initialisation with a check against isViewable() solves the issue whilst retaining mandatory field checking.