Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency tinymce to v5.2.2 [security] #1723

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 11, 2020

This PR contains the following updates:

Package Type Update Change
tinymce dependencies minor 5.1.6 -> 5.2.2

GitHub Vulnerability Alerts

CVE-2019-1010091

A cross-site scripting (XSS) vulnerability was discovered in the core parser and media plugin. The vulnerability allowed arbitrary JavaScript execution when inserting a specially crafted piece of content into the editor via the clipboard or APIs.

This vulnerability has been patched in TinyMCE 4.9.10 and 5.2.2 by improved HTML parsing and sanitization logic.

Workarounds

Disable the media plugin and manually sanitize CDATA content

References

https://www.tiny.cloud/docs/release-notes/release-notes522/#securityfixes


Release Notes

tinymce/tinymce-dist

v5.2.2

Compare Source

v5.2.1

Compare Source

v5.2.0

Compare Source


Renovate configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@edalex-ian
Copy link
Member

Heya @SammyIsConfused

It'd be great to get this merged in. Could you please review and confirm it'll all still work?

@renovate renovate bot changed the title fix(deps): update dependency tinymce to v5.2.2 [security] Update dependency tinymce to v5.2.2 [SECURITY] May 25, 2020
@renovate renovate bot changed the title Update dependency tinymce to v5.2.2 [SECURITY] fix(deps): update dependency tinymce to v5.2.2 [security] May 25, 2020
@renovate renovate bot changed the title fix(deps): update dependency tinymce to v5.2.2 [security] Update dependency tinymce to v5.2.2 [SECURITY] May 26, 2020
@renovate renovate bot changed the title Update dependency tinymce to v5.2.2 [SECURITY] fix(deps): update dependency tinymce to v5.2.2 [security] May 27, 2020
@renovate renovate bot changed the title fix(deps): update dependency tinymce to v5.2.2 [security] Update dependency tinymce to v5.2.2 [SECURITY] May 28, 2020
@renovate renovate bot changed the title Update dependency tinymce to v5.2.2 [SECURITY] fix(deps): update dependency tinymce to v5.2.2 [security] May 28, 2020
@renovate renovate bot changed the title fix(deps): update dependency tinymce to v5.2.2 [security] Update dependency tinymce to v5.2.2 [SECURITY] May 29, 2020
@SammyIsConfused
Copy link
Contributor

image
Tested and this works completely fine. I'll restart the failed builds (I'm pretty sure they just flaked) .

@edalex-ian
Copy link
Member

Cool, just need a green build of GHA and Codebuild and then we can merge. Thanks 👍

@renovate renovate bot changed the title Update dependency tinymce to v5.2.2 [SECURITY] fix(deps): update dependency tinymce to v5.2.2 [security] May 29, 2020
@renovate renovate bot force-pushed the renovate/npm-tinymce-vulnerability branch from 1f5725f to 3e5cce6 Compare May 31, 2020 23:44
@SammyIsConfused SammyIsConfused merged commit d047390 into develop Jun 1, 2020
@SammyIsConfused SammyIsConfused deleted the renovate/npm-tinymce-vulnerability branch June 1, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants