build(ci): pin ubuntu-22.04 #5166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent upgrade of ubuntu-latest to Ubuntu 24 caused a lot of issues in the community (due to missing tooling etc). As a result, just like we pin our other dependencies we should really do the same here. Hopefully renovate will also manage it for us.
|
Now considering out builds are current failing on GitHub actions, the main review will be to ensure that they fail in the same way. 😵💫 |
|
So these failures look 'correct' @PenghaiZhang . Most importantly, the workflow ran and it used the specified runner. |
|
LGTM! |
PenghaiZhang
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
A recent upgrade of ubuntu-latest to Ubuntu 24 (actions/runner-images#10636) caused a lot of issues in the community (due to missing tooling etc) and we also saw an increase in failures of a new type. As a result, just like we pin our other dependencies we should really do the same here.
Hopefully renovate will also manage it for us.