Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

[Windows] Fether window height decreases each time it's shown/hidden #442

Closed
ltfschoen opened this issue Feb 22, 2019 · 2 comments
Closed

Comments

@ltfschoen
Copy link
Contributor

ltfschoen commented Feb 22, 2019

As discovered by @Tbaut, on Windows OS, when you drag the Fether window below the bottom of the screen, each time you do it the Fether window height decreases!

We found that the cause was because the the 'resize' event listener in setupWinListeners does run on Windows 10 (incorrectly thought it didn't) in addition to the hook in setupWin32Listeners that runs also on Windows 10 (but it runs on both moved and resize events instead of just resize).

added by Thibaut:
Another way to reproduce:
* click several times on the taskbar icon, so that is shows and hide Fether. Notice how the windows shrinks.

@ltfschoen ltfschoen changed the title Fether window height decreases on Windows 10 Fether window height decreases each time dragged to bottom of screen on Windows 10 Feb 22, 2019
@Tbaut Tbaut added this to the 0.3-beta Mainnet milestone Feb 22, 2019
@ltfschoen
Copy link
Contributor Author

Noted by @Tbaut that this only happens when the Fether window isn't "frameless"

@Tbaut
Copy link
Collaborator

Tbaut commented Feb 22, 2019

Noted by @Tbaut that this only happens when the Fether window isn't "frameless"

That's a misunderstanding, I was talking about the window on Windows that is 446px instead of 515px as asked. #436

@Tbaut Tbaut changed the title Fether window height decreases each time dragged to bottom of screen on Windows 10 [Windows] Fether window height decreases each time it's shown/hidden Feb 22, 2019
@Tbaut Tbaut closed this as completed in bc4c13d Feb 25, 2019
Tbaut added a commit that referenced this issue Feb 25, 2019
fix: Fixes #442. Only run moveWindowUp when Fether window "frameless" and when showing window
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants