-
Notifications
You must be signed in to change notification settings - Fork 1.7k
parity trace_transaction showing internal calls incorrectly #1971
Comments
As a follow up, i run a few different nodes all with the following C:>"C:\Program Files\Ethcore\Parity\parity.exe" --tracing on --port 30305 --jsonrpc-port 8546 --max-peers 20 --no-signer --no-dapps On some nodes, it shows the internal calls, but others do not. Could this be an indexing issues with db ? The same trace produces inconsistent results across different nodes. Might be related to https://github.com/ethcore/parity/issues/1958 The other possibility is that this is related to the chain reorgs and parity not updating the traces correctly in these instances? I noticed that in both previous instances there were chain reorgs during those blocks |
Removing all the chain data and re syncing solves the issue, might be related to the chain re-organizations/forks and traces not getting updated/stored correctly after the re-organizaiton |
right. @debris ? |
@mtbitcoin what version(s) of parity were you running? |
The issue does not happen consistently on all block reorgs, but only on certain occasions which also appear to coincide with the chain reorgs |
this is another transaction where the issue occurs http://etherscan.io/vmtrace?txhash=0x521dfb716af4f7c123e16f9d35f435620d91ab905207263b21dd7502ef30cb80&type=parity on a 4 different nodes running parity, 3 showed the above 1 did not |
Thanks! These logs are much more helpful. I can see a pattern now |
@debris nice, hopefully we can get this resolved. I will however need to purge the trace above shortly. So please copy it down if you still need it. |
@debris Here is another one if you are looking for more patterns http://etherscan.io/vmtrace?txhash=0xc6022991c3245d93ab9a23f17bc87fdd753b13e61b0796d8e53b5109d9bf3d47&type=parity The second call should not have been there note: I've tried running the latest nightly build and the issue is still present |
I've noticed few things.
I need your help with few more things:
Conclusion: This bug is definitely chain reorg issue. I don't know yet, what causes it. I also don't know if parity is the only affected client. I assume that parity is affected, cause you mentioned I have an assumption, regarding what's happening on etherscan.io, please correct me if I'm wrong. You fetch block from geth client. Then you assume (correctly!), that transactions in parity are in the same order. You attach parity traces to geth's transactions, just looking at transaction index in given block. This causes mismatches in UI. |
@mtbitcoin we found the bug. We are working on fixing it |
@debris do you still need the info above ? |
no ;) |
fixed transaction addresses mapping, fixes #1971
It should be fixed on |
@debris slightly unrelated, but noticed that the blocks seem to be coming in slower than normal. Did anything change? or perhaps this is because it's the unstable version vs beta ? |
* Fix several RPCs (#1926) * Fix up pending receipts details. * Add support for additional params and registry over RPC. * Fix tests. * Add test, additional fix. Fixes #1932. * Fix up tests. * Fix test. * Fix test. * DB WAL size limit (#1935) * Limit WAL size * Check pruning by db modification date (#1924) * Cache address hash (#1943) * ECIES without MAC (#1948) * Use random IV for ECIES AES * ECIES encrypt/decrypt for a single message * Derive IV from shared secret * Apply settings to column families * fixed #1933 (#1979) * Fixed neighbours collection (#1996) * dapps-hosts configuration * Disabled counter check * always process trie death row on commit, add more tracing * fixed transaction addresses mapping, fixes #1971 * simplified iterator * v1.3.1 * v1.3.1
the parity trace for http://etherscan.io/vmtrace?txhash=0x7725f11b932394f67bb07dcecff9bda0dd529a4a12a98be7cf418de8d36bb2d8&type=parity shows 2 internal calls
While, a similiar trace against geth shows no calls http://etherscan.io/vmtrace?txhash=0x7725f11b932394f67bb07dcecff9bda0dd529a4a12a98be7cf418de8d36bb2d8
The address is 0x2ab9f67a27f606272189b307052694d3a2b158ba is EOA (not a contract address) and shouldn't be generating any internal calls ?
The text was updated successfully, but these errors were encountered: