Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Notify users when transaction arrives for any of their accounts #2556

Closed
jacogr opened this issue Oct 10, 2016 · 7 comments
Closed

Notify users when transaction arrives for any of their accounts #2556

jacogr opened this issue Oct 10, 2016 · 7 comments
Assignees
Labels
F8-enhancement 🎊 An additional feature request. P7-nicetohave 🐕 Issue is worth doing eventually.

Comments

@jacogr
Copy link
Contributor

jacogr commented Oct 10, 2016

No description provided.

@jacogr jacogr added F8-enhancement 🎊 An additional feature request. P7-nicetohave 🐕 Issue is worth doing eventually. M5-ui labels Oct 10, 2016
@gituser
Copy link

gituser commented Oct 11, 2016

+1 for this would be nice to have a tracking ability for accounts, maybe just like bitcoin does via walletnotify, where you can pass any bash script and it gets executed with transaction id.

@ngotchac
Copy link
Contributor

ngotchac commented Oct 25, 2016

@jacogr
Got this to work thanks to the Trace API (thus needs to be enabled), since you can make a request for transactions on several addresses (not available on Etherescan API...)
I'm not sure how would that be possible without tracing enabled then, because making a request for each account to Etherescan at each block sounds like a big overhead... Any thoughts? Maybe we should have some servers running Parity with tracing enabled... ?

@tomusdrw
Copy link
Collaborator

tomusdrw commented Oct 25, 2016

What about this: https://etherscan.io/apis#websocket ?

@ngotchac
Copy link
Contributor

Thought about this, I guess it would work. Only thing is that, for example for the list of transactions, there's a footer expliciting that Etherscan is used to get those, and here it won't. Is that an issue ?
Will try to implement it though.

@rphmeier
Copy link
Contributor

it seems a bit hacky to rely on etherscan for data which should be available from the connected parity node (pub/sub support would be nice here :) )

@jacogr
Copy link
Contributor Author

jacogr commented Oct 25, 2016

I think the correct solution would be -

  1. short-term, poll for our accounts when new block arrives (which is also currently polling, but at least abstracted away until we have proper pub-sub)
  2. medium-term use node pub-sub to provide this info same

I don't think we should rely on 3rd parties more than we already do.

@ngotchac
Copy link
Contributor

@jacogr How would we poll transactions for any account without using Etherscan anyway ?

gavofyork pushed a commit that referenced this issue Oct 25, 2016
* Added new RPC endpoints to JSAPI (#2389)

* Added modal in Account Page to test & modify password (#2389)

* Modify hint with password change // Better tabs (#2556)
ngotchac added a commit that referenced this issue Dec 9, 2016
jacogr pushed a commit that referenced this issue Dec 10, 2016
* Notify user on new transaction #2556

* Add routing to account on notification click

* Timeout of notif set to 20s
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F8-enhancement 🎊 An additional feature request. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Development

No branches or pull requests

5 participants