Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Refactoring of dapps broke local installed apps display #2771

Closed
jacogr opened this issue Oct 21, 2016 · 1 comment
Closed

Refactoring of dapps broke local installed apps display #2771

jacogr opened this issue Oct 21, 2016 · 1 comment
Assignees
Labels
F2-bug 🐞 The client fails to follow expected behavior.

Comments

@jacogr
Copy link
Contributor

jacogr commented Oct 21, 2016

2 paths -

  1. built-ins, hardcoded at this point, to be retrieved from dappreg (along with others) in teh future
  2. local apps, retrieved via /api/apps

Second option doesn't get called at this point.

In additon, the id field is wrongly named for built-ins, the sha3(name) is the actual ID as registered, it needs to be available. For built-ins the final path is overwritten, so id -> url, id to be added

  1. For external apps, id is the GithubHint contenthash (which also doubles as the dappreg id), apps loaded from 127.0.0.1:8080/ or .parity/
  2. For built-ins, the url is where the apps are loaded from, 127.0.0.1:8080/ui/.html - image retrieved from dappreg(id)->meta()->contentHash

Bear in mind the built-ins are not fetched from GithubHint and neither do they have the associated manifest. The hardcoded list of apps mimics the manifest structure, 1-to-1, so we have a built-in manifest.

@jacogr jacogr added F2-bug 🐞 The client fails to follow expected behavior. M5-ui labels Oct 21, 2016
@jacogr
Copy link
Contributor Author

jacogr commented Oct 21, 2016

@jacogr jacogr self-assigned this Oct 22, 2016
jacogr added a commit that referenced this issue Oct 22, 2016
@jacogr jacogr closed this as completed in a1266fc Oct 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F2-bug 🐞 The client fails to follow expected behavior.
Projects
None yet
Development

No branches or pull requests

1 participant