Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Creating account with empty phrase does not work as expected #4059

Closed
jacogr opened this issue Jan 5, 2017 · 1 comment
Closed

Creating account with empty phrase does not work as expected #4059

jacogr opened this issue Jan 5, 2017 · 1 comment
Assignees
@ngotchac
Labels
F2-bug 🐞 The client fails to follow expected behavior.

Comments

@jacogr
Copy link
Contributor

jacogr commented Jan 5, 2017

(To check)

From Slack -

peter [7:01 PM]
cant import account with empty recovery phrase through UI, will that be changed? if not I will change the account in the dev chain.

jacogr [8:42 PM]
Let me check, I’m sure we are supposed to allow empty phrases now.`

It is definitely supposed to allow it according to the what is intended by the code since we removed all length checks, there may be a bug with a completely empty phrase, will investigate.
@jacogr jacogr added F2-bug 🐞 The client fails to follow expected behavior. M7-ui labels Jan 5, 2017
@ngotchac ngotchac self-assigned this Jan 6, 2017
@ngotchac
Copy link
Contributor

ngotchac commented Jan 6, 2017

Can confirm

ngotchac added a commit that referenced this issue Jan 6, 2017
@ngotchac
Passwords are valid by default #4059
45b53b7
@ngotchac ngotchac mentioned this issue Jan 6, 2017
Merged
jacogr pushed a commit that referenced this issue Jan 6, 2017
@ngotchac @jacogr
Passwords are valid by default (#4075)
761ed91 
* Passwords are valid by default #4059

* Actually fixing the issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ngotchac ngotchac

Labels
F2-bug 🐞 The client fails to follow expected behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacogr @ngotchac