Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Allow specifying local accounts via CLI flag #9634

Closed
peterbitfly opened this issue Sep 24, 2018 · 0 comments
Closed

Allow specifying local accounts via CLI flag #9634

peterbitfly opened this issue Sep 24, 2018 · 0 comments
Labels
F8-enhancement 🎊 An additional feature request. M2-config 📂 Chain specifications and node configurations. P7-nicetohave 🐕 Issue is worth doing eventually. P9-somedaymaybe 🌞 Issue might be worth doing eventually.
Milestone
2.5

Comments

@peterbitfly
Copy link

  • Parity Ethereum version: N/A
  • Operating system: N/A
  • Installation: N/A
  • Fully synchronized: N/A
  • Network: N/A
  • Restarted: N/A

It would be nice if parity allows to define local accounts (=accounts whose tx should be treated as a priority when mining) can be specified via cli flags similar to what geth allow with their --txpool.locals flag (see ethereum/go-ethereum#17472)
@debris debris added the F8-enhancement 🎊 An additional feature request. label Sep 24, 2018
@peterbitfly peterbitfly changed the title Allow specifying local accounts via CLI flags Allow specifying local accounts via CLI flag Sep 24, 2018
@Tbaut Tbaut added the M2-config 📂 Chain specifications and node configurations. label Sep 25, 2018
@Tbaut Tbaut added this to the 2.3 milestone Sep 25, 2018
@5chdn 5chdn modified the milestones: 2.3, 2.4 Oct 29, 2018
@Tbaut Tbaut added P7-nicetohave 🐕 Issue is worth doing eventually. P9-somedaymaybe 🌞 Issue might be worth doing eventually. labels Nov 14, 2018
@insipx insipx self-assigned this Nov 18, 2018
insipx pushed a commit to insipx/parity-ethereum that referenced this issue Nov 24, 2018
Allow specifying local accounts via CLI
d758b77 
 * Add `tx-queue-locals` CLI option
 * ethcore: modify miner to check options vec before importing transaction

Resolves openethereum#9634
@insipx insipx mentioned this issue Nov 24, 2018
Merged
insipx pushed a commit to insipx/parity-ethereum that referenced this issue Nov 24, 2018
Allow specifying local accounts via CLI
6aba887 
 * Add `tx-queue-locals` CLI option
 * ethcore: modify miner to check options vec before importing transaction
 * modify tests (ethcore/parity)
Resolves openethereum#9634
insipx pushed a commit to insipx/parity-ethereum that referenced this issue Dec 17, 2018
@insipx
Allow specifying local accounts via CLI
6945e03 
 * Add `tx-queue-locals` CLI option
 * ethcore: modify miner to check options vec before importing transaction
 * modify tests (ethcore/parity)
Resolves openethereum#9634
insipx pushed a commit to insipx/parity-ethereum that referenced this issue Dec 17, 2018
@insipx
Allow specifying local accounts via CLI
ea3386b 
 * Add `tx-queue-locals` CLI option
 * ethcore: modify miner to check options vec before importing transaction
 * modify tests (ethcore/parity)
Resolves openethereum#9634
insipx pushed a commit to insipx/parity-ethereum that referenced this issue Dec 18, 2018
@insipx
Allow specifying local accounts via CLI
2dbcb16 
 * Add `tx-queue-locals` CLI option
 * ethcore: modify miner to check options vec before importing transaction
 * modify tests (ethcore/parity)
Resolves openethereum#9634
insipx pushed a commit to insipx/parity-ethereum that referenced this issue Dec 18, 2018
@insipx
Allow specifying local accounts via CLI
fd66f97 
 * Add `tx-queue-locals` CLI option
 * ethcore: modify miner to check options vec before importing transaction
 * modify tests (ethcore/parity)
Resolves openethereum#9634
insipx pushed a commit to insipx/parity-ethereum that referenced this issue Dec 18, 2018
@insipx
Allow specifying local accounts via CLI
ba4cc59 
 * Add `tx-queue-locals` CLI option
 * ethcore: modify miner to check options vec before importing transaction
 * modify tests (ethcore/parity)
Resolves openethereum#9634
insipx pushed a commit to insipx/parity-ethereum that referenced this issue Dec 23, 2018
@insipx
Allow specifying local accounts via CLI
e460cb5 
 * Add `tx-queue-locals` CLI option
 * ethcore: modify miner to check options vec before importing transaction
 * modify tests (ethcore/parity)
Resolves openethereum#9634
insipx pushed a commit to insipx/parity-ethereum that referenced this issue Dec 31, 2018
@insipx
Allow specifying local accounts via CLI
530002d 
 * Add `tx-queue-locals` CLI option
 * ethcore: modify miner to check options vec before importing transaction
 * modify tests (ethcore/parity)
Resolves openethereum#9634
@5chdn 5chdn modified the milestones: 2.4, 2.5 Jan 10, 2019
5chdn pushed a commit that referenced this issue Jan 28, 2019
@insipx @5chdn
Allow specifying local accounts via CLI (#9960)
50f5ccc 
* Allow specifying local accounts via CLI

 * Add `tx-queue-locals` CLI option
 * ethcore: modify miner to check options vec before importing transaction
 * modify tests (ethcore/parity)
Resolves #9634

* fix formatting

* fixes: Make prefer HashSet over Vec<>, add test, comment formatting

* Update ethcore/src/miner/miner.rs

Co-Authored-By: insipx <aplaza@liquidthink.net>

* Fix comments and add helper for set->vec conversion

* remove blank line from use statement

* fix helper test

* formatting

* fix test to pass on nightly

* revert test fix for nightly
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F8-enhancement 🎊 An additional feature request. M2-config 📂 Chain specifications and node configurations. P7-nicetohave 🐕 Issue is worth doing eventually. P9-somedaymaybe 🌞 Issue might be worth doing eventually.
Projects
None yet
Milestone
2.5
Development

No branches or pull requests
5 participants
@peterbitfly @debris @insipx @5chdn @Tbaut