Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

key_server_cluster randomly failing #9635

Closed
debris opened this issue Sep 24, 2018 · 4 comments · Fixed by #9850
Closed

key_server_cluster randomly failing #9635

debris opened this issue Sep 24, 2018 · 4 comments · Fixed by #9850
Assignees
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. F4-tests 💻 Tests need fixing, improving or augmenting. M4-core ⛓ Core client code / Rust. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Milestone

Comments

@debris
Copy link
Collaborator

debris commented Sep 24, 2018

job: https://gitlab.parity.io/parity/parity-ethereum/-/jobs/100432

pr: #9633

---- key_server_cluster::cluster::tests::ecdsa_signing_session_completes_if_node_does_not_have_a_share stdout ----
thread 'key_server_cluster::cluster::tests::ecdsa_signing_session_completes_if_node_does_not_have_a_share' panicked at 'no result in 300ms', secret_store/src/key_server_cluster/cluster.rs:1253:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::print
             at libstd/sys_common/backtrace.rs:71
             at libstd/sys_common/backtrace.rs:59
   2: std::panicking::default_hook::{{closure}}
             at libstd/panicking.rs:211
   3: std::panicking::default_hook
             at libstd/panicking.rs:221
   4: std::panicking::rust_panic_with_hook
             at libstd/panicking.rs:475
   5: std::panicking::continue_panic_fmt
             at libstd/panicking.rs:390
   6: std::panicking::begin_panic_fmt
             at libstd/panicking.rs:345
   7: ethcore_secretstore::key_server_cluster::cluster::tests::ecdsa_signing_session_completes_if_node_does_not_have_a_share
   8: <F as alloc::boxed::FnBox<A>>::call_box
             at libtest/lib.rs:1451
             at /checkout/src/libcore/ops/function.rs:223
             at /checkout/src/liballoc/boxed.rs:642
   9: __rust_maybe_catch_panic
             at libpanic_unwind/lib.rs:105

job: https://gitlab.parity.io/parity/parity-ethereum/-/jobs/100420

pr: #9360

---- key_server_cluster::cluster::tests::schnorr_signing_session_completes_if_node_does_not_have_a_share stdout ----
thread 'key_server_cluster::cluster::tests::schnorr_signing_session_completes_if_node_does_not_have_a_share' panicked at 'no result in 300ms', secret_store/src/key_server_cluster/cluster.rs:1253:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::print
             at libstd/sys_common/backtrace.rs:71
             at libstd/sys_common/backtrace.rs:59
   2: std::panicking::default_hook::{{closure}}
             at libstd/panicking.rs:211
   3: std::panicking::default_hook
             at libstd/panicking.rs:221
   4: std::panicking::rust_panic_with_hook
             at libstd/panicking.rs:475
   5: std::panicking::continue_panic_fmt
             at libstd/panicking.rs:390
   6: std::panicking::begin_panic_fmt
             at libstd/panicking.rs:345
   7: ethcore_secretstore::key_server_cluster::cluster::tests::schnorr_signing_session_completes_if_node_does_not_have_a_share
   8: <F as alloc::boxed::FnBox<A>>::call_box
             at libtest/lib.rs:1451
             at /checkout/src/libcore/ops/function.rs:223
             at /checkout/src/liballoc/boxed.rs:642
   9: __rust_maybe_catch_panic
             at libpanic_unwind/lib.rs:105

---- key_server_cluster::cluster::tests::ecdsa_signing_session_completes_if_node_does_not_have_a_share stdout ----
thread 'key_server_cluster::cluster::tests::ecdsa_signing_session_completes_if_node_does_not_have_a_share' panicked at 'no result in 300ms', secret_store/src/key_server_cluster/cluster.rs:1253:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::print
             at libstd/sys_common/backtrace.rs:71
             at libstd/sys_common/backtrace.rs:59
   2: std::panicking::default_hook::{{closure}}
             at libstd/panicking.rs:211
   3: std::panicking::default_hook
             at libstd/panicking.rs:221
   4: std::panicking::rust_panic_with_hook
             at libstd/panicking.rs:475
   5: std::panicking::continue_panic_fmt
             at libstd/panicking.rs:390
   6: std::panicking::begin_panic_fmt
             at libstd/panicking.rs:345
   7: ethcore_secretstore::key_server_cluster::cluster::tests::ecdsa_signing_session_completes_if_node_does_not_have_a_share
   8: <F as alloc::boxed::FnBox<A>>::call_box
             at libtest/lib.rs:1451
             at /checkout/src/libcore/ops/function.rs:223
             at /checkout/src/liballoc/boxed.rs:642
   9: __rust_maybe_catch_panic
             at libpanic_unwind/lib.rs:105
@debris debris added the F4-tests 💻 Tests need fixing, improving or augmenting. label Sep 24, 2018
@debris
Copy link
Collaborator Author

debris commented Sep 24, 2018

@svyatonik can you look into it?

@svyatonik
Copy link
Collaborator

Hmm...Sure

@debris
Copy link
Collaborator Author

debris commented Sep 24, 2018

Thanks! 😉

@svyatonik svyatonik self-assigned this Sep 24, 2018
@svyatonik
Copy link
Collaborator

@debris ~2 hours - still running smoothly on my laptop :/ I'd suggest adding #[ignore] for these tests if this is an urgent task - to fix this properly, I need to rewrite all tests that are using TCP/IP stack for in-test communication (i.e. almost all tests in cluster.rs). This will take some time (probably post-retreat time).

@debris debris added the F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. label Sep 24, 2018
debris added a commit that referenced this issue Sep 25, 2018
* ignore key_server_cluster randomly failing tests, related to #9635

* added explanation comment to test #[ignore]
@5chdn 5chdn added this to the 2.2 milestone Sep 25, 2018
@5chdn 5chdn added P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. M4-core ⛓ Core client code / Rust. labels Sep 25, 2018
@5chdn 5chdn modified the milestones: 2.2, 2.3 Oct 29, 2018
@5chdn 5chdn modified the milestones: 2.3, 2.4 Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. F4-tests 💻 Tests need fixing, improving or augmenting. M4-core ⛓ Core client code / Rust. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants