This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement caching for service transactions checker #10088
Implement caching for service transactions checker #10088
Changes from 10 commits
234e582
da93f5c
fbe439f
7f56abe
1f9c595
5984a41
16571bc
2bf7312
33c769f
fb74e9d
b2c127d
086cc5b
6cab68f
1ccf28c
0f4df80
cab0989
da776e9
557bd0c
cd38f3b
96e5bba
1863d90
823f383
79131c6
51bbad3
06a4b2d
ec610a3
118002c
6e73d1e
bffd73e
4e7371d
0a97ea2
aba3273
f383cec
fbcf37b
49cdf39
8c2c152
9c41cdc
93955a7
3415776
497b951
04841c6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the performance be a concern here?
registry_address
would need to query the state ifregistrar
is set.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that an issue, some cache would be nice (best would be if previously queried registry entries would be refreshed after a block is imported), but the code is not super hot (only in
\.transact
which is called by the engine, or by the miner, called only for zero-gas-price transactions attempting to enter the pool).