ci: re-enable snap publishing #10142

5chdn · 2019-01-07T11:30:14Z

I just had a shower thought this morning 🙈

gabreal · 2019-01-07T12:53:03Z

.gitlab-ci.yml

@@ -53,9 +54,6 @@ test-audit:

 build-linux:
 stage: build
- only: *releaseable_branches


so you want to run the builds on every pr?

No, this is only for testing, sorry, I will relabel it

gabreal · 2019-01-07T12:56:00Z

.gitlab-ci.yml

@@ -10,6 +10,7 @@ variables:
 CI_SERVER_NAME: "GitLab CI"
 CARGO_HOME: "${CI_PROJECT_DIR}/.cargo"
 CARGO_TARGET: x86_64-unknown-linux-gnu
+ BUILD_ARCH: amd64


IMHO for readability i would prefer to have that in the snap stage since it is not used anywhere else (but one might think so)

gabreal · 2019-01-07T12:57:42Z

.gitlab-ci.yml

+ - rust-stable
+ script:
+ - scripts/gitlab/publish-snap.sh
+ <<: *collect_artifacts


would prefer to allow it to fail for the start.

gabreal · 2019-01-07T13:02:39Z

btw, snapcraft login fails because the variable is only available on protected branches e.g. master

come-maiz · 2019-01-07T13:53:11Z

I love this thought. It's always better to have it maintained upstream :)
If you are sure about this, I'll drop the work on https://github.com/elopio/parity-snap and request the transfer back to the parity account.

5chdn · 2019-01-07T13:55:36Z

@ElOpio I'm sorry for the back and forth here. This transferring confuses me. Couldn't we both be maintainers?

scripts/gitlab/publish-snap.sh

come-maiz · 2019-01-07T13:57:13Z

.gitlab-ci.yml

+ only: *releaseable_branches
+ image: parity/snapcraft:gitlab-ci
+ variables:
+ BUILD_ARCH: amd64


This will only be amd64, right?
Any thoughts on snaps for other architectures?

Which ones did you have in mind? We basically dropped everything else

In here we are building all the possible ones, just because it's easy in that case:
https://github.com/elopio/parity-snap/blob/2b7006abad59f2ff6af211bf021bf8dd072ffece/.travis.yml#L14

Intuitively, I think arm is important. But the snap store doesn't show me metrics about that to confirm it. They might have some number accessible through the backend, I'll ask.

come-maiz · 2019-01-07T14:02:36Z

@5chdn there can be multiple collaborators on a single snap. But there can be only one publisher, which is the name that appears when you install or search for the snap:

$ snap info parity
name:      parity
summary:   The fast, light, and robust Ethereum client.
publisher: Leo Arias (elopio)

When it is upstream, it's nice to have the name of the upstream publisher. That makes the users trust more on what they are installing. It's not a big deal, I'll just ping them again in https://forum.snapcraft.io/t/transfer-parity-snap/8203 to ask for the revert. They are nice, and they get happy when an important project adopts the snap.

scripts/gitlab/publish-snap.sh

General-Beck

@5chdn You can just restore the last working state for publishing snap packages. But here everything seems to be right, you need to check with the tags.

Co-Authored-By: 5chdn <5chdn@users.noreply.github.com>

5chdn · 2019-01-09T11:10:36Z

@TriplEight could you look at this again?

TRACK=`awk -F '=' '/^track/ {print $2}' ./util/version/Cargo.toml`

case ${TRACK} in
  nightly) export GRADE="devel" CHANNEL="edge";;
  beta) export GRADE="stable" CHANNEL="beta";;
  stable) export GRADE="stable" CHANNEL="stable";;
  *) echo "No release" exit 0;;
esac

* ci: enable snap publishing~ * ci: add publish snap script * ci: add snapcraft skeleton * ci: group export statements * ci: enable snaps on pr branch * ci: enable snaps on pr branch * ci: set default BUILD_ARCH * ci: enable snaps on pr branch * ci: enable snaps on pr branch * ci: add libdb to snap * ci: reinitiate gitlabci * ci: reinitiate publish-snap script * ci: fix yaml syntax * cargo/gitlab env vars * debug, revert me * version? * debug vars * vars * vars fix * vars fix * revert * Update scripts/gitlab/publish-snap.sh Co-Authored-By: 5chdn <5chdn@users.noreply.github.com> * ci: read track from cargo toml

* version: bump beta to v2.2.6 * Update pwasm-utils to 0.6.1 (#10134) * version: mark upgrade critical on kovan * Identity fix (#10128) * fix #10125 fix service transaction version detection if --identity is enabled, change test to match how --identity actually works * fix wrong var * get the index of v, not / * idx, not idx.len() * Update ethcore/sync/src/chain/propagator.rs Co-Authored-By: joshua-mir <43032097+joshua-mir@users.noreply.github.com> * Update ethcore/sync/src/chain/propagator.rs Co-Authored-By: joshua-mir <43032097+joshua-mir@users.noreply.github.com> * change version prefix to a const * space Co-Authored-By: joshua-mir <43032097+joshua-mir@users.noreply.github.com> * [Hit return to continue] * ethcore: update hardcoded headers for foundation * ethcore: update hardcoded headers for ropsten * ethcore: update hardcoded headers for kovan * ethcore: use consistant formatting * ethcore: restore spaces after colon in chain spec * ethcore: fix bootnodes in chain specs * ethcore: fix bootnodes in chain specs * ethcore: enforce newline at the end of chainspecs * Follow-up to #10105 (#10107) * HF in POA Sokol (2019-01-04) (#10077) * HF in POA Sokol (2019-01-04) poanetwork/poa-chain-spec#91 * Update POA Core bootnodes * Autogen docs for the "Configuring Parity Ethereum" wiki page. (#10067) * publish docs changes for autogen config docs * Update publish-docs.sh adding an environment variable so js knows not to download git master and just grab the local repo * Update publish-docs.sh made some changes making this unnecessary * fix env variable env variable passes to node properly now * use yarn * test pipeline, revert me * fix test pipeline, revert me * change runner tag * change runner tag 2 * change runner tag * global git config * supress upload_files output * Update .gitlab-ci.yml reverting testing changes * Replace tag if exists Very unlikely to be important/useful * Autogen docs for the "Configuring Parity Ethereum" wiki page. (#10067) * publish docs changes for autogen config docs * Update publish-docs.sh adding an environment variable so js knows not to download git master and just grab the local repo * Update publish-docs.sh made some changes making this unnecessary * fix env variable env variable passes to node properly now * use yarn * test pipeline, revert me * fix test pipeline, revert me * change runner tag * change runner tag 2 * change runner tag * global git config * supress upload_files output * Update .gitlab-ci.yml reverting testing changes * Replace tag if exists Very unlikely to be important/useful * finality: dont require chain head to be in the chain (#10054) * Fill transaction hash on ethGetLog of light client. (#9938) * Fill transaction hash on ethGetLog of light client. This is enifficient but we keep align with spec. * Using better variables names. * Expose old fast light get log as `parity_getLogsLight`. * Update rpc/src/v1/helpers/light_fetch.rs Fix indent. Co-Authored-By: cheme <emericchevalier.pro@gmail.com> * Factor common code between light_logs and logs. * Remove useless check * Rename parity light logs to 'parity_getLogsNoTransactionHash'. Fix indent and extra white lines. * Use vec instead of tree map to avoid inner function. * better loop * fix pubsub new_blocks notifications to include all blocks (#9987) Fix: new blocks notifications sometimes missing in pubsub RPC Implement new struct to pass to `new_blocks()` with extra parameter - `has_more_blocks_to_import`, which was previously used to determine whether the notification should be sent. Now it's up to each implementation to decide what to do. Updated all implementations to behave as before, except `eth_pubsub`, which will send notification even when the queue is not empty. Update tests. * Revert part of 70a6db7 * HF in POA Core (2019-01-18) - Constantinople (#10155) poanetwork/poa-chain-spec#100 * ci: re-enable snap publishing (#10142) * ci: enable snap publishing~ * ci: add publish snap script * ci: add snapcraft skeleton * ci: group export statements * ci: enable snaps on pr branch * ci: enable snaps on pr branch * ci: set default BUILD_ARCH * ci: enable snaps on pr branch * ci: enable snaps on pr branch * ci: add libdb to snap * ci: reinitiate gitlabci * ci: reinitiate publish-snap script * ci: fix yaml syntax * cargo/gitlab env vars * debug, revert me * version? * debug vars * vars * vars fix * vars fix * revert * Update scripts/gitlab/publish-snap.sh Co-Authored-By: 5chdn <5chdn@users.noreply.github.com> * ci: read track from cargo toml * Make sure parent block is not in importing queue when importing ancient blocks (#10138) * Make sure parent block is not in importing queue when importing ancient blocks * Clear queue when an ancient import fails * Lock only once in clear * Add comments why queued check is needed * Should push the value back to the queue * Directly check in chain.read() * Remove extra empty line * Revert unused verification change

5chdn added 4 commits January 7, 2019 12:20

ci: enable snap publishing~

0ce0221

ci: add publish snap script

73a0869

ci: add snapcraft skeleton

2ea98b7

ci: group export statements

89c947a

5chdn added A0-pleasereview 🤓 Pull request needs code review. B1-patch-beta 🕷🕷 M1-ci 🙉 Continuous integration. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Jan 7, 2019

5chdn added this to the 2.3 milestone Jan 7, 2019

5chdn requested review from General-Beck and gabreal January 7, 2019 11:30

5chdn added 5 commits January 7, 2019 12:31

ci: enable snaps on pr branch

1455418

ci: enable snaps on pr branch

e6c9ee2

ci: set default BUILD_ARCH

d4e44b0

ci: enable snaps on pr branch

0eac04e

ci: enable snaps on pr branch

08137f8

gabreal approved these changes Jan 7, 2019

View reviewed changes

5chdn added 2 commits January 7, 2019 14:31

ci: add libdb to snap

101d19e

ci: reinitiate gitlabci

736a9fa

5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 7, 2019

5chdn added 2 commits January 7, 2019 14:38

ci: reinitiate publish-snap script

5c40721

ci: fix yaml syntax

287297d

5chdn mentioned this pull request Jan 7, 2019

beta backports v2.2.6 #10113

Merged

15 tasks

5chdn requested a review from TriplEight January 7, 2019 13:50

come-maiz reviewed Jan 7, 2019

View reviewed changes

scripts/gitlab/publish-snap.sh Outdated Show resolved Hide resolved

come-maiz reviewed Jan 7, 2019

View reviewed changes

TriplEight added 8 commits January 7, 2019 21:33

cargo/gitlab env vars

7dcf922

debug, revert me

efa2da1

version?

d94181c

debug vars

86340aa

vars

dbea690

vars fix

c1fbd60

vars fix

68f735a

revert

ea0c4de

TriplEight suggested changes Jan 8, 2019

View reviewed changes

scripts/gitlab/publish-snap.sh Outdated Show resolved Hide resolved

scripts/gitlab/publish-snap.sh Outdated Show resolved Hide resolved

General-Beck approved these changes Jan 8, 2019

View reviewed changes

TriplEight and others added 2 commits January 9, 2019 12:06

Update scripts/gitlab/publish-snap.sh

a7ca051

Co-Authored-By: 5chdn <5chdn@users.noreply.github.com>

ci: read track from cargo toml

14264fe

TriplEight approved these changes Jan 9, 2019

View reviewed changes

5chdn merged commit f9a8aac into master Jan 9, 2019

5chdn deleted the a5-ci-snapcraft branch January 9, 2019 13:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: re-enable snap publishing #10142

ci: re-enable snap publishing #10142

5chdn commented Jan 7, 2019

gabreal Jan 7, 2019

5chdn Jan 7, 2019

gabreal Jan 7, 2019

gabreal Jan 7, 2019

5chdn Jan 7, 2019 •

edited

Loading

gabreal commented Jan 7, 2019

come-maiz commented Jan 7, 2019

5chdn commented Jan 7, 2019

come-maiz Jan 7, 2019

5chdn Jan 7, 2019 •

edited

Loading

come-maiz Jan 7, 2019

come-maiz commented Jan 7, 2019

General-Beck left a comment

5chdn commented Jan 9, 2019

ci: re-enable snap publishing #10142

ci: re-enable snap publishing #10142

Conversation

5chdn commented Jan 7, 2019

gabreal Jan 7, 2019

Choose a reason for hiding this comment

5chdn Jan 7, 2019

Choose a reason for hiding this comment

gabreal Jan 7, 2019

Choose a reason for hiding this comment

gabreal Jan 7, 2019

Choose a reason for hiding this comment

5chdn Jan 7, 2019 • edited Loading

Choose a reason for hiding this comment

gabreal commented Jan 7, 2019

come-maiz commented Jan 7, 2019

5chdn commented Jan 7, 2019

come-maiz Jan 7, 2019

Choose a reason for hiding this comment

5chdn Jan 7, 2019 • edited Loading

Choose a reason for hiding this comment

come-maiz Jan 7, 2019

Choose a reason for hiding this comment

come-maiz commented Jan 7, 2019

General-Beck left a comment

Choose a reason for hiding this comment

5chdn commented Jan 9, 2019

5chdn Jan 7, 2019 •

edited

Loading

5chdn Jan 7, 2019 •

edited

Loading