Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Make specification of protocol in SyncRequester::send_request explicit #10295

Merged
merged 12 commits into from
Feb 8, 2019
Merged

Make specification of protocol in SyncRequester::send_request explicit #10295

merged 12 commits into from
Feb 8, 2019

Commits on Feb 4, 2019

  1. * Make the specification of the protocol to which a packet_id belongs to 

      explicit when calling "SyncRequester::send_packet".

* Remove "SyncIO::send" and leave only "SyncIO::send_protocol"
    Fernando Herrero Carrón committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    27a6d98 View commit details
    Browse the repository at this point in the history

  2. Adapt tests to new code.

    Fernando Herrero Carrón committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    584ed4f View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Strengthen tests to check if packet_id and protocol match when sending 

    a devp2p packet.
    Fernando Herrero Carrón committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    aecfb1f View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. Early proposal for binding packet_id and protocol together 

    in chain sync.
    Fernando Herrero Carrón committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    0bef1ce View commit details
    Browse the repository at this point in the history

  2. Replace PacketId with SyncPacketId in chain sync.

    Fernando Herrero Carrón committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    5d8bc34 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2019

  1. Rename module.

    Fernando Herrero Carrón committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    afd1431 View commit details
    Browse the repository at this point in the history

  2. Remove send_protocol from SyncIo and leave just send.

    Fernando Herrero Carrón committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    1d9ae78 View commit details
    Browse the repository at this point in the history

  3. Rename trait Packet to PacketInfo.

    Fernando Herrero Carrón committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    16afb11 View commit details
    Browse the repository at this point in the history

  4. Document.

    Fernando Herrero Carrón committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    81022bf View commit details
    Browse the repository at this point in the history

  5. Revert "Early proposal for binding packet_id and protocol together" 

    This reverts commit 0bef1ce.
    Fernando Herrero Carrón committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    9dbdd15 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into fhc-explicit-protocol-send-request

    @elferdo
    elferdo authored Feb 8, 2019
    Configuration menu
    Copy the full SHA
    349eae0 View commit details
    Browse the repository at this point in the history

  7. Fix conflict merge error.

    Fernando Herrero Carrón committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    7b245ba View commit details
    Browse the repository at this point in the history