This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
refactor: evmbin: CLI flag for coloured log levels. CLI flag for output to log file #10761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like @ltfschoen signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
16 tasks
ltfschoen
changed the title
refactor: evmbin: Additional serialization. CLI flag for log levels with colour and output to log file
refactor: evmbin: CLI flag for coloured log levels. CLI flag for output to log file
Jun 19, 2019
Update based on feedback from @todr - Max level trace in development - Max level info in production (i.e. cargo build -p evmbin --release) - Only show date and target file name when debug or trace log level used.
3 tasks
… default log level * Switch to more visible log colour * Add missing license header * Move use of default log level to CLI declaration, for same approach as was done in #10810
…um and Whisper CLIs * Update Readme and CLI config so they are consistent. * Use logging level 0 (Error) for evmbin CLI consistency in Readme and CLI config * Rename `log_level` to `logging` (consistent with parity-ethereum crate CLI that is frequently used), as suggested here #10810 (comment) * Update test to test all CLI commands including logging level and logging to file
ltfschoen
added
the
A3-stale 🍃
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
label
Jul 26, 2019
closing as stale |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-pleasereview 🤓
Pull request needs code review.
A3-stale 🍃
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of PR #10657.
Not to be merged prior to #10657 and #10742
--logging
to choose log level (consistent with parity-ethereum CLI)--logging-to-file
to save outputs to output.logcargo build -p evmbin --release
) toinfo!
in Cargo.toml. In development users may usedebug!
ortrace!
.ANS: Note that we cannot convert writing to the stdout buffer with
writeln!
in std_json.rs to writing directly to stdout by use of macros with color likeinfo!
. See the module doc comments in std_json.rsThe changes may be tested as follows:
std-json
json
output to a file output.log