ethcore/res: add mordor testnet configuration #11200

soc1c · 2019-10-24T09:04:59Z

Adds Mordor Classic testnet. https://github.com/eth-classic/mordor/

Will replace the ancient dinosaur Morden Classic testnet in the future.

Release notes:

default testnet is Görli now (was: Kovan)
activates Agharta (ECIP-1061) hardfork:
- 5_000_381 on Morden Classic Testnet (November 13, 2019)
- 301_243 on Mordor Classic Testnet (November 20, 2019)
- 1_705_549 on Kotti Classic Testnet (December 11, 2019)

ref https://github.com/ethereumclassic/ECIPs/pull/155/files

dvdplm · 2019-10-24T10:11:06Z

parity/account_utils.rs

@@ -81,7 +81,7 @@ mod accounts {
 		let account_settings = AccountProviderSettings {
 			unlock_keep_secret: cfg.enable_fast_unlock,
 			blacklisted_accounts: 	match *spec {


For my education, what is this blacklist for? The docs are oxymoronic: "/// Disallowed accounts.". What did 00a329c0648769a73afac7f9381e08fb43dbea72do to become blacklisted?

It is a relict from the parity wallet UI. there was a chance that a user did not follow instructions and recovered an account from an empty seed phrase. this account is blacklisted from mainnet usage for safety reasons. but as we no longer have the wallet, we could also remove this.

dvdplm · 2019-10-24T10:16:06Z

parity/params.rs

 			"rinkeby" => SpecType::Rinkeby,
-			"goerli" | "görli" => SpecType::Goerli,
+			"goerli" | "görli" | "testnet" => SpecType::Goerli,


Hmm, how about we remove "testnet" altogether? What is it useful for?

Sorry, I missed the explanation in the PR descr. Something for the relnotes then (cc @s3krit)

it's a legacy option. I'm open to removing it.

Let's do that.

Made a note to myself for the release notes. Thanks

ordian · 2019-10-24T10:30:26Z

ethcore/res/ethereum/mordor.json

+            "name":"alt_bn128_add",
+            "eip1108_transition": "0x7fffffffffffff",
+            "pricing":{
+               "alt_bn128_const_operations": {


we would probably want to adapt it to the new format after #11039 is merged

I wouldn't see #11039 as blocker for this PR, but happy to convert it.

no, I'm just saying whichever will be merged last, gets to fix it, since we're making a breaking change in #11039

I'm not sure we'll backport #11039 so we might need to have it both ways. :/

sorry @soc1c but this needs to be resolved after #11039

eip1108_params are removed

ordian

Let's merge it first and deal with new spec format in #11039.
(I haven't verified the correctness of Morder spec, but other changes look fine)

soc1c · 2019-10-29T11:41:31Z

Also activated ECIP-1061 for morden and kotti

ref https://github.com/ethereumclassic/ECIPs/pull/155/files

niklasad1

#11039 removed eip1108 params, thus the chain specs needs to be updated to the new format. It is unfortunately not documented yet.

So I guess you could:

Take a peek at an example https://github.com/paritytech/parity-ethereum/blob/master/ethcore/res/ethereum/rinkeby.json#L124-#L138
Read the PR description of [builtin]: support multiple prices and activations in chain spec #11039
I can help you with it

…1-config-mordor

soc1c · 2019-11-02T10:26:47Z

@niklasad1 like this? fe55bbd

niklasad1

LGTM

* ethcore/res: add mordor testnet configuration * ethcore/spec: add mordor testnet configuration * parity/cli: add mordor testnet configuration * parity/config: fix tests * ethcore/res: update mordor spec with agharta hardfork block 301243 * ethcore/res: update kotti with agharta block 1705549 * ethcore/res: update morden with agharta block 5000381 * ethcore/res: multiple prices and activations for mordor testnet * fix mordor spec json * fix mordor spec json

* ethcore-builtin (#10850) * ethcore-builtin * rename ethcore-builtin Impl to Implementation * [builtin]: support `multiple prices and activations` in chain spec (#11039) * [builtin]: impl new builtin type Have an enum to deserialize either a builtin of a single price or several prices * [builtin]: style cleanup * [builtin]: fix tests * [builtin]: replace boxing with wrapper enum * cleanup * fix: make it backward compatible with old builtin * fix: update chain specs * fix: revert use of `type alias` on enum The CI doesn't use the latest rust. This commit reverts that change * fix: builtin tests * fix: revert use of `type alias` on enum * [basic-authority]: update test-chainspec * fix failing tests * [builtin]: multi-prices add `info field` It might be hard to read chain specs with several activations points. This commit introduces a `info` field which may be used to write some information about the current activation such as: `Istanbul hardfork EIP-1108` or something similar. * fix: bad rebase Co-Authored-By: David <dvdplm@gmail.com> * fix(grumbles): make it backward compatible * grumbles: resolve `NOTE` * revert chain specs changes * rename test Co-Authored-By: David <dvdplm@gmail.com> * [builtin docs]: price -> Fixed price Co-Authored-By: Andronik Ordian <write@reusable.software> * [json]: address naming grumbles InnerPricing -> PricingInner PriceWithActivationAt -> PricingAt * docs: revert changes for `AltBn128ConstOperations` * [json]: usize -> u64 Use explicit types to cope with platform dependent issues for `usize` * grumble: simplify `spec_backward_compability.json` * docs: add issue link to `TODO` * [builtin]: replace `match` with `map` * [builtin]: add deprecation message `eip1108` params * nits * [json spec tests]: fix json indentation * [json docs]: fix typos * [json]: `compability layer` + deser to BTreeMap Previously we had to match `Pricing::Single` and `PricingMulti` which this fixes. It does by introducing a compability layer and into() implemenentation. In addition, I switched the deserialization to `BTreeMap` instead of `Vec`. That changes the format of the chain spec again * [json]: rename `BuiltinCombat` -> `BuiltinCompat` * Update ethcore/builtin/src/lib.rs Co-Authored-By: David <dvdplm@gmail.com> * [json builtin]: improve docs Co-Authored-By: David <dvdplm@gmail.com> * [json builtin]: improve docs Co-Authored-By: David <dvdplm@gmail.com> * chore(builtin): sort dependencies * [json builtin]: deprecate `eip1108` params * [machine]: add bench for calling builtin contract * [machine]: reduce calls to `Builtin::is_active` * [builtin]: fix nits * [json]: revert breakage of chain specs * [json builtin]: remove `eip1108` params * [chain specs]: update to new format * [machine]: revert changes * [devp2p]: revert change * [builtin]: doc nits * manually adjust spec * [chain specs]: activate `Istanbul` on mainnet (#11228) * [chains spec]: activate istanbul at mainnet * Activate `Block >= 9,069,000` on the Ethereum mainnet * Enable Blake2 compression function `F` precompile * [chain specs]: add comments for EIP1108 activation * [chainspec mainnet]: enable Istanbul transitions * [chainspec mainnet]: simply configuration * ethcore/res: add mordor testnet configuration (#11200) * ethcore/res: add mordor testnet configuration * ethcore/spec: add mordor testnet configuration * parity/cli: add mordor testnet configuration * parity/config: fix tests * ethcore/res: update mordor spec with agharta hardfork block 301243 * ethcore/res: update kotti with agharta block 1705549 * ethcore/res: update morden with agharta block 5000381 * ethcore/res: multiple prices and activations for mordor testnet * fix mordor spec json * fix mordor spec json * fix bad merge * [ethereum tests]: revert `725dbc73a725dbc73a`

* ethcore/res: add mordor testnet configuration * ethcore/spec: add mordor testnet configuration * parity/cli: add mordor testnet configuration * parity/config: fix tests * ethcore/res: update mordor spec with agharta hardfork block 301243 * ethcore/res: update kotti with agharta block 1705549 * ethcore/res: update morden with agharta block 5000381 * ethcore/res: multiple prices and activations for mordor testnet * fix mordor spec json * fix mordor spec json

* master: (21 commits) ropsten #6631425 foundation #8798209 (#11201) Update list of bootnodes for xDai chain (#11236) ethcore/res: add mordor testnet configuration (#11200) [chain specs]: activate `Istanbul` on mainnet (#11228) [builtin]: support `multiple prices and activations` in chain spec (#11039) Insert explicit warning into the panic hook (#11225) Snapshot restoration overhaul (#11219) Fix docker centos build (#11226) retry on gitlab system failures (#11222) Update bootnodes. (#11203) Use provided usd-per-eth value if an endpoint is specified (#11209) Use a lock instead of atomics for snapshot Progress (#11197) [informant]: `MillisecondDuration` -> `as_millis()` (#11211) Step duration map configuration parameter ported from the POA Network fork (#10902) Upgrade jsonrpc to latest (#11206) [export hardcoded sync]: use debug for `H256` (#11204) Pause pruning while snapshotting (#11178) Type annotation for next_key() matching of json filter options (#11192) Crypto primitives removed from ethkey (#11174) Made ecrecover implementation trait public (#11188) ...

* ropsten #6631425 foundation #8798209 (#11201) * [stable] builtin, istanbul and mordor testnet backports (#11234) * ethcore-builtin (#10850) * [builtin]: support `multiple prices and activations` in chain spec (#11039) * [chain specs]: activate `Istanbul` on mainnet (#11228) * ethcore/res: add mordor testnet configuration (#11200) * Update list of bootnodes for xDai chain (#11236) * ethcore: remove `test-helper feat` from build (#11047) * Secret store: fix Instant::now() related race in net_keep_alive (#11155) (#11159) * [stable]: backport #10691 and #10683 (#11143) * Fix compiler warning (that will become an error) (#10683) * Refactor Clique stepping (#10691) * Add Constantinople eips to the dev (instant_seal) config (#10809) * Add cargo-remote dir to .gitignore (?) * Insert explicit warning into the panic hook (#11225) * Fix docker centos build (#11226) * Update MIX bootnodes. (#11203) * Use provided usd-per-eth value if an endpoint is specified (#11209) * Add new line after writing block to hex file. (#10984) * Type annotation for next_key() matching of json filter options (#11192) (but no `FilterOption` in 2.5 so…) * Upgrade jsonrpc to latest (#11206) * [CI] check evmbin build (#11096) * Correct EIP-712 encoding (#11092) * [client]: Fix for incorrectly dropped consensus messages (#11086) * Fix block detail updating (#11015) * Switching sccache from local to Redis (#10971) * Made ecrecover implementation trait public (#11188) * [dependencies]: jsonrpc `14.0.1` (#11183) * [receipt]: add `sender` & `receiver` to `RichReceipts` (#11179) * [ethcore/builtin]: do not panic in blake2pricer on short input (#11180) * util Host: fix a double Read Lock bug in fn Host::session_readable() (#11175) * ethcore client: fix a double Read Lock bug in fn Client::logs() (#11172) * Change how RPCs eth_call and eth_estimateGas handle "Pending" (#11127) * Cleanup stratum a bit (#11161) * Upgrade to jsonrpc v14 (#11151) * SecretStore: expose restore_key_public in HTTP API (#10241)

* [CI] check evmbin build (#11096) * Correct EIP-712 encoding (#11092) * [client]: Fix for incorrectly dropped consensus messages (#11082) (#11086) * Update hardcoded headers (foundation, classic, kovan, xdai, ewc, ...) (#11053) * Add cargo-remote dir to .gitignore (?) * Update light client headers: ropsten 6631425 foundation 8798209 (#11201) * Update list of bootnodes for xDai chain (#11236) * ethcore/res: add mordor testnet configuration (#11200) * [chain specs]: activate Istanbul on mainnet (#11228) * [builtin]: support multiple prices and activations in chain spec (#11039) * [receipt]: add sender & receiver to RichReceipts (#11179) * [ethcore/builtin]: do not panic in blake2pricer on short input (#11180) * Made ecrecover implementation trait public (#11188) * Fix docker centos build (#11226) * Update MIX bootnodes. (#11203) * Insert explicit warning into the panic hook (#11225) * Use provided usd-per-eth value if an endpoint is specified (#11209) * Cleanup stratum a bit (#11161) * Add Constantinople EIPs to the dev (instant_seal) config (#10809) (already backported) * util Host: fix a double Read Lock bug in fn Host::session_readable() (#11175) * ethcore client: fix a double Read Lock bug in fn Client::logs() (#11172) * Type annotation for next_key() matching of json filter options (#11192) * Upgrade jsonrpc to latest (#11206) * [dependencies]: jsonrpc 14.0.1 (#11183) * Upgrade to jsonrpc v14 (#11151) * Switching sccache from local to Redis (#10971) * Snapshot restoration overhaul (#11219) * Add new line after writing block to hex file. (#10984) * Pause pruning while snapshotting (#11178) * Change how RPCs eth_call and eth_estimateGas handle "Pending" (#11127) * Fix block detail updating (#11015) * Make InstantSeal Instant again #11186 * Filter out some bad ropsten warp snapshots (#11247)

soc1c added 3 commits October 24, 2019 10:52

ethcore/res: add mordor testnet configuration

d4996f1

ethcore/spec: add mordor testnet configuration

2499b2f

parity/cli: add mordor testnet configuration

e9bbc00

soc1c added A0-pleasereview 🤓 Pull request needs code review. B1-patch-beta 🕷🕷 M2-config 📂 Chain specifications and node configurations. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Oct 24, 2019

soc1c added this to the 2.7 milestone Oct 24, 2019

This comment has been minimized.

Sign in to view

soc1c mentioned this pull request Oct 24, 2019

client integration tracker eth-classic/mordor#3

Closed

5 tasks

parity/config: fix tests

7585324

soc1c added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Oct 24, 2019

dvdplm reviewed Oct 24, 2019

View reviewed changes

ordian reviewed Oct 24, 2019

View reviewed changes

ordian approved these changes Oct 29, 2019

View reviewed changes

soc1c added 3 commits October 29, 2019 12:11

ethcore/res: update mordor spec with agharta hardfork block 301243

a9bafda

ethcore/res: update kotti with agharta block 1705549

bd1c7b8

ethcore/res: update morden with agharta block 5000381

5da3db1

soc1c added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 29, 2019

niklasad1 suggested changes Nov 2, 2019

View reviewed changes

niklasad1 added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Nov 2, 2019

soc1c added 2 commits November 2, 2019 11:18

Merge branch 'master' of github.com:paritytech/parity-ethereum into s…

d5ab017

…1-config-mordor

ethcore/res: multiple prices and activations for mordor testnet

fe55bbd

soc1c added 2 commits November 2, 2019 11:34

fix mordor spec json

23f1beb

fix mordor spec json

b42c98b

niklasad1 approved these changes Nov 2, 2019

View reviewed changes

niklasad1 added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Nov 2, 2019

soc1c merged commit 1b4d23f into master Nov 2, 2019

soc1c deleted the s1-config-mordor branch November 2, 2019 11:26

This was referenced Nov 5, 2019

v2.5.10 stable #11239

Merged

v2.6.5 beta #11240

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ethcore/res: add mordor testnet configuration #11200

ethcore/res: add mordor testnet configuration #11200

soc1c commented Oct 24, 2019 •

edited

Loading

This comment has been minimized.

dvdplm Oct 24, 2019

soc1c Oct 24, 2019

dvdplm Oct 24, 2019

dvdplm Oct 24, 2019

soc1c Oct 24, 2019

dvdplm Oct 24, 2019

s3krit Oct 24, 2019

ordian Oct 24, 2019

soc1c Oct 24, 2019

ordian Oct 24, 2019

dvdplm Oct 24, 2019

niklasad1 Nov 2, 2019 •

edited

Loading

ordian left a comment

soc1c commented Oct 29, 2019

niklasad1 left a comment

soc1c commented Nov 2, 2019

niklasad1 left a comment

ethcore/res: add mordor testnet configuration #11200

ethcore/res: add mordor testnet configuration #11200

Conversation

soc1c commented Oct 24, 2019 • edited Loading

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niklasad1 Nov 2, 2019 • edited Loading

Choose a reason for hiding this comment

ordian left a comment

Choose a reason for hiding this comment

soc1c commented Oct 29, 2019

niklasad1 left a comment

Choose a reason for hiding this comment

soc1c commented Nov 2, 2019

niklasad1 left a comment

Choose a reason for hiding this comment

soc1c commented Oct 24, 2019 •

edited

Loading

niklasad1 Nov 2, 2019 •

edited

Loading