-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
What was the reason you did this? Like, what's the gain having them split in two? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Did you notice any difference in the benches? I don't expect much of an impact, but you never know.
The function was taking an additional argument -
No, I forgot to alter the |
* master: Clarify what first_block `None` means (#11269) removed redundant VMType enum with one variant (#11266) Ensure jsonrpc threading settings are sane (#11267) Return Ok(None) when the registrar contract returns empty slice (#11257) Add a benchmark for snapshot::account::to_fat_rlps() (#11185) Fix misc compile warnings (#11258) simplify verification (#11249)
This pr attempts to simplify a bit a header/block verification process.
Changes:
NoopVerifier
as it was never usedNoopVerifier
, the only remaining implementation ofVerifier
wasCanonVerifier
so I also removed it as well as the trait itselffn verify_block_family
is no longer optional. (it was always called withSome
)fn verify_header_params
into 2 functions:fn verify_header_params
fn verify_header_time
which does only timestamp verification of the header