Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add benchmarks and tests for RlpNodeCodec decoding #11287

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Add benchmarks and tests for RlpNodeCodec decoding #11287

merged 1 commit into from
Dec 3, 2019

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented Nov 25, 2019

Add a few benchmarks for RlpNodeCodec. Comparing with the old code I could not detect any significant changes.

@dvdplm dvdplm self-assigned this Nov 25, 2019
@dvdplm dvdplm added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). F4-tests 💻 Tests need fixing, improving or augmenting. labels Nov 25, 2019
@ordian ordian merged commit 4c3be46 into master Dec 3, 2019
@ordian ordian deleted the dp-chore-benchmarks-for-RlpNodeCodec branch December 3, 2019 11:30
@ordian ordian added this to the 2.7 milestone Dec 3, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 3, 2019
ordian added a commit that referenced this pull request Dec 3, 2019
@ordian
Merge branch 'master' into dp/chore/use-upstream-rocksdb
12fceb8 
* master:
  add support for evan.network chains (#11289)
  Add benchmarks and tests for RlpNodeCodec decoding (#11287)
  upgrade vergen to 3.0 (#11293)
  interruptible test and build jobs (#11294)
  Istanbul HF on POA Sokol (#11282)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sorpaas sorpaas sorpaas approved these changes

@ordian ordian ordian approved these changes

Assignees

@dvdplm dvdplm

Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. F4-tests 💻 Tests need fixing, improving or augmenting.
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@dvdplm @ordian @sorpaas