Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix Aztlan hard fork issues #11347

Merged
merged 8 commits into from
Jan 13, 2020
Merged

Fix Aztlan hard fork issues #11347

merged 8 commits into from
Jan 13, 2020

Conversation

sorpaas
Copy link
Collaborator

@sorpaas sorpaas commented Dec 20, 2019

This fixes an incorrect configuration for Ethereum Classic Aztlan hard fork. The thing is, eip1283_transition plus eip1706_transition only equals EIP-2200 when EIP-1884 is enabled, but Aztlan does not enable EIP-1884. So for this we must create a special condition.

@sorpaas sorpaas added the A0-pleasereview 🤓 Pull request needs code review. label Dec 20, 2019
Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorpaas can you provide some additional info regarding aztlan hardfork?

The code looks good but I found this one tricky to review

@niklasad1 niklasad1 added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 13, 2020
@ordian ordian added M2-config 📂 Chain specifications and node configurations. M4-core ⛓ Core client code / Rust. labels Jan 13, 2020
@ordian ordian added this to the 2.7 milestone Jan 13, 2020
@ordian ordian merged commit d8a0d38 into master Jan 13, 2020
@ordian ordian deleted the sp-aztlan-fix branch January 13, 2020 21:54
"balance": "0x1",
"builtin": {
"name": "blake2_f",
"activate_at": "0x1f67cf",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 0xa03ae7

#11391

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M2-config 📂 Chain specifications and node configurations. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants