This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
reviewed
Jan 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sorpaas can you provide some additional info regarding aztlan hardfork
?
The code looks good but I found this one tricky to review
niklasad1
reviewed
Jan 13, 2020
niklasad1
reviewed
Jan 13, 2020
niklasad1
approved these changes
Jan 13, 2020
niklasad1
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Jan 13, 2020
ordian
added
M2-config 📂
Chain specifications and node configurations.
M4-core ⛓
Core client code / Rust.
labels
Jan 13, 2020
ordian
approved these changes
Jan 13, 2020
6 tasks
q9f
reviewed
Jan 20, 2020
"balance": "0x1", | ||
"builtin": { | ||
"name": "blake2_f", | ||
"activate_at": "0x1f67cf", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 0xa03ae7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A8-looksgood 🦄
Pull request is reviewed well.
M2-config 📂
Chain specifications and node configurations.
M4-core ⛓
Core client code / Rust.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an incorrect configuration for Ethereum Classic Aztlan hard fork. The thing is,
eip1283_transition
pluseip1706_transition
only equals EIP-2200 when EIP-1884 is enabled, but Aztlan does not enable EIP-1884. So for this we must create a special condition.