Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix alpine docker image entry point #11749

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Fix alpine docker image entry point #11749

merged 2 commits into from
Jun 16, 2020

Conversation

voron
Copy link

@voron voron commented Jun 1, 2020

Alpine docker image uses relative path at entrypoint, it breaks compatibility with parity image, I get an error while running openethereum/openethereum container with workdir changed to non-default value

Error response from daemon: OCI runtime create failed: container_linux.go:346: starting container process caused "exec: \"./openethereum\": stat ./openethereum: no such file or directory": unknown

@voron
Copy link
Author

voron commented Jun 2, 2020

I've added jq to make openethereum docker-image usable as drop-in replacement of parity docker image, we use jq to parse curl output in k8s liveness check script

@voron
Copy link
Author

voron commented Jun 9, 2020

@adria0 @denisgranha pls review this tiny PR.

@denisgranha denisgranha merged commit 2d75036 into openethereum:master Jun 16, 2020
@voron voron deleted the fix-docker-entrypoint branch June 16, 2020 13:26
dvdplm added a commit that referenced this pull request Jun 30, 2020
* master:
  Update parity-crypto dependency (#11791)
  ethcore/private-tcx: fix deadlock caused by conflicting lock order (#11764)
  Feature/publish draft release ci (#11786)
  Trigger custom docker build when adding ci-build-docker to the commit (#11782)
  Fix alpine docker image entry point (#11749)
  Use BigUint::modpow for ModExp precompile (#11772)
  Add YOLO-1 testnet (#11757)
  Upgrade num to 0.2, use enum-primitive-derive (#11636)
  Update Simple Subroutines to the latest spec  (#11731)
  update secret-store reference (#11761)
  Implementation of EIP 2537 (#11707)
  Add missing forks to fork ID (#11747)
  Use nightly tag for master branch (#11732)
dvdplm added a commit that referenced this pull request Jun 30, 2020
…ereum/openethereum into dp/chore/upgrade-to-rocksdb-0.14

* 'dp/chore/upgrade-to-rocksdb-0.14' of github.com:openethereum/openethereum:
  Update parity-crypto dependency (#11791)
  ethcore/private-tcx: fix deadlock caused by conflicting lock order (#11764)
  Feature/publish draft release ci (#11786)
  Trigger custom docker build when adding ci-build-docker to the commit (#11782)
  Fix alpine docker image entry point (#11749)
  Use BigUint::modpow for ModExp precompile (#11772)
  Add YOLO-1 testnet (#11757)
  Upgrade num to 0.2, use enum-primitive-derive (#11636)
  Update Simple Subroutines to the latest spec  (#11731)
  update secret-store reference (#11761)
  Implementation of EIP 2537 (#11707)
  Add missing forks to fork ID (#11747)
  Use nightly tag for master branch (#11732)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants