Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Bump memory-db lib to 0.24.1 and add shrink_to_fit #11760 #11827

Merged
merged 2 commits into from
Aug 1, 2020

Conversation

rakita
Copy link

@rakita rakita commented Jul 27, 2020

@rakita rakita requested review from vorot93 and adria0 July 27, 2020 07:50
@rakita
Copy link
Author

rakita commented Jul 27, 2020

Tested for four days, everything function as expected.

Copy link

@adria0 adria0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rakita
Copy link
Author

rakita commented Jul 28, 2020

Not sure why, but test unrelated to this pull request fails on macos: command is cargo test -p ethstore-cli --test cli i tried it on my windows machine and linux server and both tests pass. I dont have mac to check this

     Running `/Users/runner/work/openethereum/openethereum/target/release/deps/cli-608eb763b339d18b`

running 1 test
test cli_cmd ... FAILED

failures:

---- cli_cmd stdout ----
thread 'cli_cmd' panicked at 'assertion failed: output.status.success()', accounts/ethstore/cli/tests/cli.rs:29:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    cli_cmd

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '-p ethstore-cli --test cli'

@rakita rakita force-pushed the rakita/shrink_to_fit branch 3 times, most recently from c51138e to b27bfa5 Compare July 29, 2020 11:58
@sorpaas sorpaas added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. M4-core ⛓ Core client code / Rust. labels Jul 29, 2020
@rakita
Copy link
Author

rakita commented Jul 31, 2020

Blocked. The test fails on macos because of updated memory-db and I don't have platform to debug this.

@vorot93
Copy link

vorot93 commented Jul 31, 2020

Test failure is not related to this pull request.

@sorpaas sorpaas merged commit 1c8cef6 into master Aug 1, 2020
@sorpaas sorpaas deleted the rakita/shrink_to_fit branch August 1, 2020 13:06
@sorpaas sorpaas added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants