This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Validating sha3 of a dapp bundle #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 37bffd3 on dapps-valid into * on master*. |
| @@ -155,6 +158,45 @@ impl From<zip::result::ZipError> for ValidationError { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| fn sha3(file: &mut fs::File) -> Result<H256, io::Error> { | |||
There was a problem hiding this comment.
worth pulling this out into util/sha3.rs - it could be used for my latest PR.
There was a problem hiding this comment.
yes, but better would be a generic implementation for any R: Read so that you can sha3 a buffered reader as well as reading from a raw fd (which is a lot less efficient in general)
added 2 commits
August 24, 2016 14:13
debris
added
A8-looksgood 🦄
|
Changes Unknown when pulling 23b7ac4 on dapps-valid into * on master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New address for testing (morden):
http://04084ce8a748854f55a3a16ec7a2831f520990180b07706af646336e17935aeb.parity/previous hash was calculated from incorrect bundle (master vs specific commit)