Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixing serde overflow error (#1977) #2031

Merged
merged 3 commits into from
Sep 5, 2016
Merged

Conversation

debris
Copy link
Collaborator

@debris debris commented Sep 1, 2016

No description provided.

@debris debris added A0-pleasereview 🤓 Pull request needs code review. A8-backport 🕸 Pull request is already reviewed well in another branch. labels Sep 1, 2016
@debris debris mentioned this pull request Sep 1, 2016
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 1, 2016
@debris
Copy link
Collaborator Author

debris commented Sep 1, 2016

updated also secp library, cause travis was failing to compile it

@rphmeier rphmeier added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Sep 1, 2016
@rphmeier
Copy link
Contributor

rphmeier commented Sep 2, 2016

rust-beta build is failing, looks like a type inference error of some kind.

@debris
Copy link
Collaborator Author

debris commented Sep 5, 2016

I fixed the issues. Now rustc beta failed 3 times in a row with

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated

But I believe that it is still worth merging since current stable has issues with compiling with rustc stable

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Sep 5, 2016
@arkpar arkpar merged commit 77ecf4d into stable Sep 5, 2016
@debris debris deleted the backport_overflow_fix_stable branch September 5, 2016 10:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-backport 🕸 Pull request is already reviewed well in another branch. A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants